From 047b5752b7969ffc987cd46a909b6bc72ebb236b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Oliveira?= <josepfo.w@gmail.com>
Date: Thu, 13 May 2021 22:46:47 +0100
Subject: [PATCH] refactor: move config validator from coin utils to ccxt
 common

---
 lib/coin-utils.js            | 7 +------
 lib/plugins/common/ccxt.js   | 7 ++++++-
 lib/plugins/exchange/ccxt.js | 4 ++--
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/lib/coin-utils.js b/lib/coin-utils.js
index 3eab3885..e460760c 100644
--- a/lib/coin-utils.js
+++ b/lib/coin-utils.js
@@ -67,7 +67,7 @@ const CRYPTO_CURRENCIES = [
   }
 ]
 
-module.exports = { buildUrl, cryptoDir, blockchainDir, configPath, cryptoCurrencies, getCryptoCurrency, toUnit, isConfigValid }
+module.exports = { buildUrl, cryptoDir, blockchainDir, configPath, cryptoCurrencies, getCryptoCurrency, toUnit }
 
 function getCryptoCurrency (cryptoCode) {
   const cryptoCurrency = _.find(['cryptoCode', cryptoCode], CRYPTO_CURRENCIES)
@@ -109,8 +109,3 @@ function toUnit (cryptoAtoms, cryptoCode) {
   const unitScale = cryptoRec.unitScale
   return cryptoAtoms.shift(-unitScale)
 }
-
-function isConfigValid (config, fields) {
-  const values = _.map(it => _.get(it)(config))(fields)
-  return _.every(it => it || it === 0)(values)
-}
diff --git a/lib/plugins/common/ccxt.js b/lib/plugins/common/ccxt.js
index df180489..0a0ed232 100644
--- a/lib/plugins/common/ccxt.js
+++ b/lib/plugins/common/ccxt.js
@@ -34,4 +34,9 @@ function verifyFiatSupport (fiatCode, serviceName) {
   return fiat === 'ALL_CURRENCIES' ? true : _.includes(fiatCode, fiat)
 }
 
-module.exports = { buildMarket, ALL, verifyFiatSupport }
+function isConfigValid (config, fields) {
+  const values = _.map(it => _.get(it)(config))(fields)
+  return _.every(it => it || it === 0)(values)
+}
+
+module.exports = { buildMarket, ALL, verifyFiatSupport, isConfigValid }
diff --git a/lib/plugins/exchange/ccxt.js b/lib/plugins/exchange/ccxt.js
index 748ed06a..7ab27794 100644
--- a/lib/plugins/exchange/ccxt.js
+++ b/lib/plugins/exchange/ccxt.js
@@ -1,8 +1,8 @@
 const _ = require('lodash/fp')
 const ccxt = require('ccxt')
 
-const { toUnit, isConfigValid } = require('../../coin-utils')
-const { buildMarket, ALL } = require('../common/ccxt')
+const { toUnit } = require('../../coin-utils')
+const { buildMarket, ALL, isConfigValid } = require('../common/ccxt')
 const { ORDER_TYPES } = require('./consts')
 
 const DEFAULT_PRICE_PRECISION = 2