Merge pull request #1068 from chaotixkilla/fix-multi-coin-install

Prevent multiple blockchains to be installed simultaneously

lib/blockchain/install.js

@@ -9,6 +9,8 @@ const _ = require('lodash/fp')
 
 const { utils: coinUtils } = require('lamassu-coins')
 const options = require('../options')
+const settingsLoader = require('../new-settings-loader')
+const wallet = require('../wallet')
 
 const common = require('./common')
 const doVolume = require('./do-volume')
@@ -112,6 +114,35 @@ function plugin (crypto) {
   return plugin
 }
 
+function getBlockchainSyncStatus (cryptoList) {
+  const installedCryptos = _.reduce((acc, value) => ({ ...acc, [value.cryptoCode]: isInstalledSoftware(value) && isInstalledVolume(value) }), {}, cryptoList)
+
+  return settingsLoader.loadLatest()
+    .then(settings => {
+      const installedButNotConfigured = []
+      const blockchainStatuses = _.reduce((acc, value) => {
+          const processStatus = common.es(`sudo supervisorctl status ${value.code} | awk '{ print $2 }'`).trim()
+          return acc.then(a => {
+            return wallet.checkBlockchainStatus(settings, value.cryptoCode)
+              .then(res => _.includes(value.cryptoCode, _.keys(installedCryptos)) ? Promise.resolve({ ...a, [value.cryptoCode]: res }) : Promise.resolve({ ...a }))
+              .catch(() => {
+                if (processStatus === 'RUNNING') {
+                  installedButNotConfigured.push(value.cryptoCode)
+                  return Promise.resolve({ ...a, [value.cryptoCode]: 'syncing' })
+                }
+                return Promise.resolve({ ...a })
+              })
+          })
+        },
+        Promise.resolve({}),
+        cryptoList
+      )
+
+      return Promise.all([blockchainStatuses, installedButNotConfigured])
+    })
+    .then(([blockchainStatuses, installedButNotConfigured]) => ({ blockchainStatuses, installedButNotConfigured }))
+}
+
 function run () {  
   const choices = _.flow([
     _.filter(c => c.type !== 'erc-20'),
@@ -129,13 +160,40 @@ function run () {
 
   const questions = []
 
+  const validateAnswers = async (answers) => {
+    if (_.size(answers) > 2) return { message: `Please insert a maximum of two coins to install.`, isValid: false }
+    return getBlockchainSyncStatus(cryptos)
+      .then(({ blockchainStatuses, installedButNotConfigured }) => {
+        if (!_.isEmpty(installedButNotConfigured)) {
+          logger.warn(`Detected ${_.join(' and ', installedButNotConfigured)} installed on this machine, but couldn't establish connection. ${_.size(installedButNotConfigured) === 1 ? `Is this plugin` : `Are these plugins`} configured via admin?`)
+        }
+
+        const result = _.reduce((acc, value) => ({ ...acc, [value]: _.isNil(acc[value]) ? 1 : acc[value] + 1 }), {}, _.values(blockchainStatuses))
+        if (_.size(answers) + result.syncing > 2) {
+          return { message: `Installing these coins would pass the 2 parallel blockchain synchronization limit. Please try again with fewer coins or try again later.`, isValid: false }
+        }
+
+        if (result.syncing > 2) {
+          return { message: `There are currently more than 2 blockchains in their initial synchronization. Please try again later.`, isValid: false }
+        }
+
+        return { message: null, isValid: true }
+      })
+  }
+
   questions.push({
     type: 'checkbox',
     name: 'crypto',
-    message: 'Which cryptocurrencies would you like to install?',
+    message: 'Which cryptocurrencies would you like to install?\nTo prevent server resource overloading, only TWO coins should be syncing simultaneously.\nMore coins can be installed after this process is over.',
     choices
   })
 
   inquirer.prompt(questions)
-    .then(answers => processCryptos(answers.crypto))
+    .then(answers => Promise.all([validateAnswers(answers.crypto), answers]))
+    .then(([res, answers]) => {
+      if (res.isValid) {
+        return processCryptos(answers.crypto)
+      }
+      logger.error(res.message)
+    })
 }

lib/plugins/wallet/bitcoincashd/bitcoincashd.js

@@ -123,6 +123,12 @@ function supportsBatching (cryptoCode) {
     .then(() => SUPPORTS_BATCHING)
 }
 
+function checkBlockchainStatus (cryptoCode) {
+  return checkCryptoCode(cryptoCode)
+    .then(() => fetch('getblockchaininfo'))
+    .then(res => !!res['initialblockdownload'] ? 'syncing' : 'ready')
+}
+
 module.exports = {
   balance,
   sendCoins,
@@ -130,5 +136,6 @@ module.exports = {
   getStatus,
   newFunding,
   cryptoNetwork,
-  supportsBatching
+  supportsBatching,
+  checkBlockchainStatus
 }

lib/plugins/wallet/bitcoind/bitcoind.js

@@ -176,6 +176,12 @@ function supportsBatching (cryptoCode) {
     .then(() => SUPPORTS_BATCHING)
 }
 
+function checkBlockchainStatus (cryptoCode) {
+  return checkCryptoCode(cryptoCode)
+    .then(() => fetch('getblockchaininfo'))
+    .then(res => !!res['initialblockdownload'] ? 'syncing' : 'ready')
+}
+
 module.exports = {
   balance,
   sendCoins,
@@ -186,5 +192,6 @@ module.exports = {
   fetchRBF,
   estimateFee,
   sendCoinsBatch,
-  supportsBatching
+  supportsBatching,
+  checkBlockchainStatus
 }

lib/plugins/wallet/bitgo/bitgo.js

@@ -164,6 +164,11 @@ function supportsBatching (cryptoCode) {
     .then(() => SUPPORTS_BATCHING)
 }
 
+function checkBlockchainStatus (cryptoCode) {
+  return checkCryptoCode(cryptoCode)
+    .then(() => Promise.resolve('ready'))
+}
+
 module.exports = {
   NAME,
   balance,
@@ -172,5 +177,6 @@ module.exports = {
   getStatus,
   newFunding,
   cryptoNetwork,
-  supportsBatching
+  supportsBatching,
+  checkBlockchainStatus
 }

lib/plugins/wallet/dashd/dashd.js

@@ -118,11 +118,18 @@ function supportsBatching (cryptoCode) {
     .then(() => SUPPORTS_BATCHING)
 }
 
+function checkBlockchainStatus (cryptoCode) {
+  return checkCryptoCode(cryptoCode)
+    .then(() => fetch('getblockchaininfo'))
+    .then(res => !!res['initialblockdownload'] ? 'syncing' : 'ready')
+}
+
 module.exports = {
   balance,
   sendCoins,
   newAddress,
   getStatus,
   newFunding,
-  supportsBatching
+  supportsBatching,
+  checkBlockchainStatus
 }

lib/plugins/wallet/geth/base.js

@@ -32,7 +32,8 @@ module.exports = {
   privateKey,
   isStrictAddress,
   connect,
-  supportsBatching
+  supportsBatching,
+  checkBlockchainStatus
 }
 
 function connect (url) {
@@ -230,3 +231,9 @@ function supportsBatching (cryptoCode) {
   return checkCryptoCode(cryptoCode)
     .then(() => SUPPORTS_BATCHING)
 }
+
+function checkBlockchainStatus (cryptoCode) {
+  return checkCryptoCode(cryptoCode)
+    .then(pify(web3.eth.isSyncing))
+    .then(res => _.isObject(res) ? 'syncing' : 'ready')
+}

lib/plugins/wallet/litecoind/litecoind.js

@@ -118,11 +118,18 @@ function supportsBatching (cryptoCode) {
     .then(() => SUPPORTS_BATCHING)
 }
 
+function checkBlockchainStatus (cryptoCode) {
+  return checkCryptoCode(cryptoCode)
+    .then(() => fetch('getblockchaininfo'))
+    .then(res => !!res['initialblockdownload'] ? 'syncing' : 'ready')
+}
+
 module.exports = {
   balance,
   sendCoins,
   newAddress,
   getStatus,
   newFunding,
-  supportsBatching
+  supportsBatching,
+  checkBlockchainStatus
 }

lib/plugins/wallet/mock-wallet/mock-wallet.js

@@ -115,6 +115,11 @@ function supportsBatching (cryptoCode) {
   return Promise.resolve(_.includes(cryptoCode, BATCHABLE_COINS))
 }
 
+function checkBlockchainStatus (cryptoCode) {
+  return checkCryptoCode(cryptoCode)
+    .then(() => Promise.resolve('ready'))
+}
+
 module.exports = {
   NAME,
   balance,
@@ -123,5 +128,6 @@ module.exports = {
   newAddress,
   getStatus,
   newFunding,
-  supportsBatching
+  supportsBatching,
+  checkBlockchainStatus
 }

lib/plugins/wallet/monerod/monerod.js

@@ -205,6 +205,30 @@ function supportsBatching (cryptoCode) {
     .then(() => SUPPORTS_BATCHING)
 }
 
+function checkBlockchainStatus (cryptoCode) {
+  return checkCryptoCode(cryptoCode)
+  .then(() => {
+    try {
+      const config = jsonRpc.parseConf(configPath)
+  
+      // Daemon uses a different connection of the wallet
+      const rpcConfig = {
+        username: config['rpc-login'].split(':')[0],
+        password: config['rpc-login'].split(':')[1],
+        port: cryptoRec.defaultPort
+      }
+  
+      return jsonRpc.fetchDigest(rpcConfig, 'get_info')
+        .then(res => {
+          console.log('res XMR', res)
+          return !!res.synchronized ? 'ready' : 'syncing'
+        })
+    } catch (err) {
+      throw new Error('XMR daemon is currently not installed')
+    }
+  })
+}
+
 module.exports = {
   balance,
   sendCoins,
@@ -212,5 +236,6 @@ module.exports = {
   getStatus,
   newFunding,
   cryptoNetwork,
-  supportsBatching
+  supportsBatching,
+  checkBlockchainStatus
 }

lib/plugins/wallet/zcashd/zcashd.js

@@ -144,11 +144,18 @@ function supportsBatching (cryptoCode) {
     .then(() => SUPPORTS_BATCHING)
 }
 
+function checkBlockchainStatus (cryptoCode) {
+  return checkCryptoCode(cryptoCode)
+    .then(() => fetch('getblockchaininfo'))
+    .then(res => !!res['initial_block_download_complete'] ? 'ready' : 'syncing')
+}
+
 module.exports = {
   balance,
   sendCoins,
   newAddress,
   getStatus,
   newFunding,
-  supportsBatching
+  supportsBatching,
+  checkBlockchainStatus
 }

lib/wallet.js

@@ -237,6 +237,11 @@ function supportsBatching (settings, cryptoCode) {
     .then(r => r.wallet.supportsBatching(cryptoCode))
 }
 
+function checkBlockchainStatus (settings, cryptoCode) {
+  return fetchWallet(settings, cryptoCode)
+    .then(r => r.wallet.checkBlockchainStatus(cryptoCode))
+}
+
 const coinFilter = ['ETH']
 
 const balance = (settings, cryptoCode) => {
@@ -265,5 +270,6 @@ module.exports = {
   isHd,
   newFunding,
   cryptoNetwork,
-  supportsBatching
+  supportsBatching,
+  checkBlockchainStatus
 }