From 15e4cba0dcc271126e4598ec7c98918fb93d9bf9 Mon Sep 17 00:00:00 2001
From: Rafael Taranto <rafael.taranto@protonmail.com>
Date: Mon, 30 Jun 2025 07:17:41 +0100
Subject: [PATCH] fix: fiat balance notification recycler label

---
 .../sections/FiatBalanceAlerts.jsx            | 131 +++++++++---------
 .../sections/FiatBalanceOverrides.jsx         |  34 ++---
 2 files changed, 86 insertions(+), 79 deletions(-)

diff --git a/packages/admin-ui/src/pages/Notifications/sections/FiatBalanceAlerts.jsx b/packages/admin-ui/src/pages/Notifications/sections/FiatBalanceAlerts.jsx
index 287d38d1..d6ff6871 100644
--- a/packages/admin-ui/src/pages/Notifications/sections/FiatBalanceAlerts.jsx
+++ b/packages/admin-ui/src/pages/Notifications/sections/FiatBalanceAlerts.jsx
@@ -149,73 +149,78 @@ const FiatBalance = ({ section, fieldWidth = 80 }) => {
               )}
             </div>
           </Form>
-          <Form>
-            <PromptWhenDirty />
-            <Header
-              title="Cash recycling"
-              editing={isEditing(RECYCLER_STACKER_KEY)}
-              disabled={isDisabled(RECYCLER_STACKER_KEY)}
-              setEditing={it => setEditing(RECYCLER_STACKER_KEY, it)}
-            />
-            <div className="flex flex-wrap gap-8">
-              {R.chain(
-                it => [
-                  <>
-                    <div className="flex w-50 gap-4">
-                      <Cashbox
-                        percent={
-                          values[
-                            `fillingPercentageRecycler${(it + 1) * 2 - 1}`
-                          ] ?? data[`recycler${(it + 1) * 2 - 1}`]
-                        }
-                        isLow={false}
-                        className="border-4 inline-block"
-                        omitInnerPercentage
-                        cashOut
-                      />
-                      <div className="w-30">
-                        <TL2 className="mt-0">Recycler {(it + 1) * 2 - 1}</TL2>
-                        <EditableNumber
-                          label="Alert me under"
-                          name={`fillingPercentageRecycler${(it + 1) * 2 - 1}`}
-                          editing={isEditing(RECYCLER_STACKER_KEY)}
-                          displayValue={x => (x === '' ? '-' : x)}
-                          decoration="%"
-                          width={fieldWidth}
+          {maxNumberOfRecyclers > 0 && (
+            <Form>
+              <PromptWhenDirty />
+              <Header
+                title="Cash recycling"
+                editing={isEditing(RECYCLER_STACKER_KEY)}
+                disabled={isDisabled(RECYCLER_STACKER_KEY)}
+                setEditing={it => setEditing(RECYCLER_STACKER_KEY, it)}
+              />
+              <div className="flex flex-wrap gap-8">
+                {R.chain(
+                  it => [
+                    <>
+                      <div className="flex w-50 gap-4">
+                        <Cashbox
+                          percent={
+                            values[
+                              `fillingPercentageRecycler${(it + 1) * 2 - 1}`
+                            ] ?? data[`recycler${(it + 1) * 2 - 1}`]
+                          }
+                          isLow={false}
+                          className="border-4 inline-block"
+                          omitInnerPercentage
+                          cashOut
                         />
+                        <div className="w-30">
+                          <TL2 className="mt-0">
+                            Recycler {(it + 1) * 2 - 1}
+                          </TL2>
+                          <EditableNumber
+                            label="Alert me under"
+                            name={`fillingPercentageRecycler${(it + 1) * 2 - 1}`}
+                            editing={isEditing(RECYCLER_STACKER_KEY)}
+                            displayValue={x => (x === '' ? '-' : x)}
+                            decoration="%"
+                            width={fieldWidth}
+                          />
+                        </div>
                       </div>
-                    </div>
-                  </>,
-                  <>
-                    <div className="flex w-50 gap-4">
-                      <Cashbox
-                        percent={
-                          values[`fillingPercentageRecycler${(it + 1) * 2}`] ??
-                          data[`recycler${(it + 1) * 2}`]
-                        }
-                        isLow={false}
-                        className="border-4 inline-block"
-                        omitInnerPercentage
-                        cashOut
-                      />
-                      <div className="w-30">
-                        <TL2 className="mt-0">Recycler {(it + 1) * 2}</TL2>
-                        <EditableNumber
-                          label="Alert me under"
-                          name={`fillingPercentageRecycler${(it + 1) * 2}`}
-                          editing={isEditing(RECYCLER_STACKER_KEY)}
-                          displayValue={x => (x === '' ? '-' : x)}
-                          decoration="%"
-                          width={fieldWidth}
+                    </>,
+                    <>
+                      <div className="flex w-50 gap-4">
+                        <Cashbox
+                          percent={
+                            values[
+                              `fillingPercentageRecycler${(it + 1) * 2}`
+                            ] ?? data[`recycler${(it + 1) * 2}`]
+                          }
+                          isLow={false}
+                          className="border-4 inline-block"
+                          omitInnerPercentage
+                          cashOut
                         />
+                        <div className="w-30">
+                          <TL2 className="mt-0">Recycler {(it + 1) * 2}</TL2>
+                          <EditableNumber
+                            label="Alert me under"
+                            name={`fillingPercentageRecycler${(it + 1) * 2}`}
+                            editing={isEditing(RECYCLER_STACKER_KEY)}
+                            displayValue={x => (x === '' ? '-' : x)}
+                            decoration="%"
+                            width={fieldWidth}
+                          />
+                        </div>
                       </div>
-                    </div>
-                  </>,
-                ],
-                R.times(R.identity, maxNumberOfRecyclers / 2),
-              )}
-            </div>
-          </Form>
+                    </>,
+                  ],
+                  R.times(R.identity, maxNumberOfRecyclers / 2),
+                )}
+              </div>
+            </Form>
+          )}
         </div>
       )}
     </Formik>
diff --git a/packages/admin-ui/src/pages/Notifications/sections/FiatBalanceOverrides.jsx b/packages/admin-ui/src/pages/Notifications/sections/FiatBalanceOverrides.jsx
index 3b726e84..03fb7092 100644
--- a/packages/admin-ui/src/pages/Notifications/sections/FiatBalanceOverrides.jsx
+++ b/packages/admin-ui/src/pages/Notifications/sections/FiatBalanceOverrides.jsx
@@ -185,22 +185,24 @@ const FiatBalanceOverrides = ({ config, section }) => {
   )
 
   return (
-    <EditableTable
-      name={NAME}
-      title="Overrides"
-      error={error?.message}
-      enableDelete
-      enableEdit
-      enableCreate
-      save={it => save(section, validationSchema.cast(it))}
-      initialValues={initialValues}
-      validationSchema={validationSchema}
-      forceDisable={isDisabled(NAME) || !machines}
-      data={setupValues}
-      elements={elements}
-      disableAdd={!suggestions?.length}
-      setEditing={innerSetEditing}
-    />
+    <div className="mt-4">
+      <EditableTable
+        name={NAME}
+        title="Overrides"
+        error={error?.message}
+        enableDelete
+        enableEdit
+        enableCreate
+        save={it => save(section, validationSchema.cast(it))}
+        initialValues={initialValues}
+        validationSchema={validationSchema}
+        forceDisable={isDisabled(NAME) || !machines}
+        data={setupValues}
+        elements={elements}
+        disableAdd={!suggestions?.length}
+        setEditing={innerSetEditing}
+      />
+    </div>
   )
 }