From 1d37608a191dfd0e565278e3917e8890607195ba Mon Sep 17 00:00:00 2001
From: Nikola Ubavic <53820106+ubavic@users.noreply.github.com>
Date: Mon, 15 Aug 2022 16:13:25 +0200
Subject: [PATCH] feat: change average to median

---
 .../src/pages/Analytics/Analytics.js           | 18 ++++++++----------
 .../components/wrappers/OverTimeWrapper.js     |  4 ++--
 .../pages/Analytics/graphs/OverTimeDotGraph.js |  8 ++++----
 3 files changed, 14 insertions(+), 16 deletions(-)

diff --git a/new-lamassu-admin/src/pages/Analytics/Analytics.js b/new-lamassu-admin/src/pages/Analytics/Analytics.js
index 5e8d94bd..2bf8e278 100644
--- a/new-lamassu-admin/src/pages/Analytics/Analytics.js
+++ b/new-lamassu-admin/src/pages/Analytics/Analytics.js
@@ -227,13 +227,11 @@ const Analytics = () => {
     previous: filteredData(period.code).previous.length
   }
 
-  const avgAmount = {
-    current:
-      R.sum(R.map(d => d.fiat, filteredData(period.code).current)) /
-      (txs.current === 0 ? 1 : txs.current),
-    previous:
-      R.sum(R.map(d => d.fiat, filteredData(period.code).previous)) /
-      (txs.previous === 0 ? 1 : txs.previous)
+  const median = values => (values.length === 0 ? 0 : R.median(values))
+
+  const medianAmount = {
+    current: median(R.map(d => d.fiat, filteredData(period.code).current)),
+    previous: median(R.map(d => d.fiat, filteredData(period.code).previous))
   }
 
   const txVolume = {
@@ -365,9 +363,9 @@ const Analytics = () => {
             />
             <div className={classes.verticalLine} />
             <OverviewEntry
-              label="Avg. txn amount"
-              value={avgAmount.current}
-              oldValue={avgAmount.previous}
+              label="Median amount"
+              value={medianAmount.current}
+              oldValue={medianAmount.previous}
               currency={fiatLocale}
             />
             <div className={classes.verticalLine} />
diff --git a/new-lamassu-admin/src/pages/Analytics/components/wrappers/OverTimeWrapper.js b/new-lamassu-admin/src/pages/Analytics/components/wrappers/OverTimeWrapper.js
index def8fe90..6efaaf40 100644
--- a/new-lamassu-admin/src/pages/Analytics/components/wrappers/OverTimeWrapper.js
+++ b/new-lamassu-admin/src/pages/Analytics/components/wrappers/OverTimeWrapper.js
@@ -31,7 +31,7 @@ const OverTimeDotGraphHeader = ({
     cashIn: <div className={classes.cashInIcon}></div>,
     cashOut: <div className={classes.cashOutIcon}></div>,
     transaction: <div className={classes.txIcon}></div>,
-    average: (
+    median: (
       <svg height="12" width="18">
         <path
           stroke={primaryColor}
@@ -55,7 +55,7 @@ const OverTimeDotGraphHeader = ({
               IconElement={legend.transaction}
               label={'One transaction'}
             />
-            <LegendEntry IconElement={legend.average} label={'Average'} />
+            <LegendEntry IconElement={legend.median} label={'Median'} />
           </Box>
         </div>
         <div className={classes.graphHeaderRight}>
diff --git a/new-lamassu-admin/src/pages/Analytics/graphs/OverTimeDotGraph.js b/new-lamassu-admin/src/pages/Analytics/graphs/OverTimeDotGraph.js
index bf705a09..9da30a97 100644
--- a/new-lamassu-admin/src/pages/Analytics/graphs/OverTimeDotGraph.js
+++ b/new-lamassu-admin/src/pages/Analytics/graphs/OverTimeDotGraph.js
@@ -498,9 +498,9 @@ const Graph = ({
 
   const buildAvg = useCallback(
     g => {
-      const mean = d3.mean(data, d => new BigNumber(d.fiat).toNumber()) ?? 0
+      const median = d3.median(data, d => new BigNumber(d.fiat).toNumber()) ?? 0
 
-      if (log && mean === 0) return
+      if (log && median === 0) return
 
       g.attr('stroke', primaryColor)
         .attr('stroke-width', 3)
@@ -508,8 +508,8 @@ const Graph = ({
         .call(g =>
           g
             .append('line')
-            .attr('y1', 0.5 + y(mean))
-            .attr('y2', 0.5 + y(mean))
+            .attr('y1', 0.5 + y(median))
+            .attr('y2', 0.5 + y(median))
             .attr('x1', GRAPH_MARGIN.left)
             .attr('x2', GRAPH_WIDTH)
         )