Merge pull request #1537 from CrypticaScriptura/commission-limits2

LAM-863 fix: use percentMin for overrides
This commit is contained in:
Rafael Taranto 2023-06-15 19:34:58 +01:00 committed by GitHub
commit 205d2ec984

View file

@ -227,6 +227,7 @@ const overrides = (auxData, currency, auxElements) => {
return getOverridesFields(getData, currency, auxElements)
}
const percentMin = -15
const percentMax = 100
const getSchema = locale => {
const bills = getBillOptions(locale, denominations).map(it => it.code)
@ -235,12 +236,12 @@ const getSchema = locale => {
return Yup.object().shape({
cashIn: Yup.number()
.label('Cash-in')
.min(0)
.min(percentMin)
.max(percentMax)
.required(),
cashOut: Yup.number()
.label('Cash-out')
.min(0)
.min(percentMin)
.max(percentMax)
.required(),
fixedFee: Yup.number()
@ -330,12 +331,12 @@ const getOverridesSchema = (values, rawData, locale) => {
.min(1),
cashIn: Yup.number()
.label('Cash-in')
.min(0)
.min(percentMin)
.max(percentMax)
.required(),
cashOut: Yup.number()
.label('Cash-out')
.min(0)
.min(percentMin)
.max(percentMax)
.required(),
fixedFee: Yup.number()
@ -441,12 +442,12 @@ const getListCommissionsSchema = locale => {
.min(1),
cashIn: Yup.number()
.label('Cash-in')
.min(0)
.min(percentMin)
.max(percentMax)
.required(),
cashOut: Yup.number()
.label('Cash-out')
.min(0)
.min(percentMin)
.max(percentMax)
.required(),
fixedFee: Yup.number()