From 23eadc171750fb7a7b86a474310fcf78a426e422 Mon Sep 17 00:00:00 2001 From: siiky Date: Mon, 23 Oct 2023 10:19:07 +0100 Subject: [PATCH] refactor: use destructuring instead of indexing --- lib/plugins.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/plugins.js b/lib/plugins.js index 60fd51d4..df97d8d7 100644 --- a/lib/plugins.js +++ b/lib/plugins.js @@ -152,11 +152,9 @@ function plugins (settings, deviceId) { const sumTxs = (sum, tx) => { // cash-out-helper sends 0 as fallback value, need to filter it out as there are no '0' denominations const bills = _.filter(it => _.includes('recycler', it.name) && it.denomination > 0, tx.bills) - const sameDenominations = a => a[0]?.denomination === a[1]?.denomination - const doDenominationsMatch = _.every(sameDenominations, _.zip(recyclers, bills)) - - if (!doDenominationsMatch) { + const sameDenominations = ([recycler, bill]) => recycler?.denomination === bill?.denomination + if (!_.every(sameDenominations, _.zip(recyclers, bills))) { throw new Error('Denominations don\'t add up, recyclers were changed.') }