From 24807a70ef741b8fe0864147048bc23ed59827ca Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9rgio=20Salgado?= <sergiodiassalgado@gmail.com>
Date: Mon, 4 Apr 2022 17:04:37 +0100
Subject: [PATCH] fix: cashbox batches log possible NaN and null values

---
 lib/cashbox-batches.js | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/lib/cashbox-batches.js b/lib/cashbox-batches.js
index e180fa37..a23ec25f 100644
--- a/lib/cashbox-batches.js
+++ b/lib/cashbox-batches.js
@@ -72,22 +72,25 @@ function getBillsByBatchId (id) {
 function logFormatter (data) {
   return _.map(
     it => {
+      const bills = _.filter(
+        ite => !(_.isNil(ite) || _.isNil(ite.fiat_code) || _.isNil(ite.fiat) || _.isNaN(ite.fiat)),
+        it.bills
+      )
       return {
         id: it.id,
         deviceId: it.deviceId,
         created: it.created,
         operationType: it.operationType,
-        performedBy: it.performedBy,
-        billCount: _.size(it.bills),
+        billCount: _.size(bills),
         fiatTotals: _.reduce(
           (acc, value) => {
             acc[value.fiat_code] = (acc[value.fiat_code] || 0) + value.fiat
             return acc
           },
           {},
-          it.bills
+          bills
         ),
-        billsByDenomination: _.countBy(ite => `${ite.fiat} ${ite.fiat_code}`, it.bills)
+        billsByDenomination: _.countBy(ite => `${ite.fiat} ${ite.fiat_code}`, bills)
       }
     },
     data