chore: migrating to nodejs 22

.tool-versions

@@ -1 +1 @@
-nodejs 14
+nodejs 22

bin/lamassu-register

@@ -3,7 +3,7 @@
 require('../lib/environment-helper')
 const { asyncLocalStorage, defaultStore } = require('../lib/async-storage')
 const userManagement = require('../lib/new-admin/graphql/modules/userManagement')
-const authErrors = require('../lib/new-admin/graphql/errors/authentication')
+const authErrors = require('../lib/new-admin/graphql/errors')
 
 const name = process.argv[2]
 const role = process.argv[3]

bin/new-graphql-dev-insecure

@@ -1,5 +0,0 @@
-#!/usr/bin/env node
-
-const adminServer = require('../lib/new-admin/graphql-dev-insecure')
-
-adminServer.run()

lib/app.js

@@ -1,11 +1,10 @@
 const fs = require('fs')
-const http = require('http')
 const https = require('https')
 const argv = require('minimist')(process.argv.slice(2))
 
 require('./environment-helper')
 const { asyncLocalStorage, defaultStore } = require('./async-storage')
-const routes = require('./routes')
+const { loadRoutes } = require('./routes')
 const logger = require('./logger')
 const poller = require('./poller')
 const settingsLoader = require('./new-settings-loader')
@@ -16,8 +15,7 @@ const ofacUpdate = require('./ofac/update')
 
 const KEY_PATH = process.env.KEY_PATH
 const CERT_PATH = process.env.CERT_PATH
-
-const devMode = argv.dev
+const CA_PATH = process.env.CA_PATH
 
 const version = require('../package.json').version
 logger.info('Version: %s', version)
@@ -40,7 +38,7 @@ function run () {
           .then(settings => {
             clearInterval(handler)
             return loadSanctions(settings)
-              .then(() => startServer(settings))
+              .then(startServer)
               .then(resolve)
           })
           .catch(errorHandler)
@@ -68,30 +66,27 @@ function loadSanctions (settings) {
     })
 }
 
-function startServer (settings) {
-  return Promise.resolve()
-    .then(() => {
-      poller.setup(['public'])
-      const httpsServerOptions = {
-        key: fs.readFileSync(KEY_PATH),
-        cert: fs.readFileSync(CERT_PATH),
-        requestCert: true,
-        rejectUnauthorized: false
-      }
+async function startServer () {
+  const app = await loadRoutes()
 
-      const server = devMode
-        ? http.createServer(routes.app)
-        : https.createServer(httpsServerOptions, routes.app)
+  poller.setup(['public'])
 
-      const port = argv.port || 3000
+  const httpsServerOptions = {
+    key: fs.readFileSync(KEY_PATH),
+    cert: fs.readFileSync(CERT_PATH),
+    ca: fs.readFileSync(CA_PATH),
+    requestCert: true,
+    rejectUnauthorized: false
+  }
 
-      if (devMode) logger.info('In dev mode')
+  const server = https.createServer(httpsServerOptions, app)
 
-      server.listen(port, () => {
-        logger.info('lamassu-server listening on port ' +
-        port + ' ' + (devMode ? '(http)' : '(https)'))
-      })
-    })
+  const port = argv.port || 3000
+
+  await new Promise((resolve) =>
+    server.listen({ port }, resolve),
+  )
+  logger.info(`lamassu-server listening on port ${port}`)
 }
 
 module.exports = { run }

lib/customers.js

@@ -276,6 +276,7 @@ function deleteEditedData (id, data) {
 async function updateEditedPhoto (id, photo, photoType) {
   const newPatch = {}
   const baseDir = photoType === 'frontCamera' ? FRONT_CAMERA_DIR : ID_PHOTO_CARD_DIR
+  console.log('photo', photo)
   const { createReadStream, filename } = photo
   const stream = createReadStream()
 

lib/graphql/server.js

@@ -1,27 +1,27 @@
 const logger = require('../logger')
 
-const https = require('https')
-const { ApolloServer } = require('apollo-server-express')
+const { ApolloServer } = require('@apollo/server')
 
 const devMode = !!require('minimist')(process.argv.slice(2)).dev
 
-module.exports = new ApolloServer({
+const context = ({ req, res }) => ({
+  deviceId: req.deviceId, /* lib/middlewares/populateDeviceId.js */
+  deviceName: req.deviceName, /* lib/middlewares/authorize.js */
+  operatorId: res.locals.operatorId, /* lib/middlewares/operatorId.js */
+  pid: req.query.pid,
+  settings: req.settings, /* lib/middlewares/populateSettings.js */
+})
+
+const graphQLServer = new ApolloServer({
   typeDefs: require('./types'),
   resolvers: require('./resolvers'),
-  context: ({ req, res }) => ({
-    deviceId: req.deviceId, /* lib/middlewares/populateDeviceId.js */
-    deviceName: req.deviceName, /* lib/middlewares/authorize.js */
-    operatorId: res.locals.operatorId, /* lib/middlewares/operatorId.js */
-    pid: req.query.pid,
-    settings: req.settings, /* lib/middlewares/populateSettings.js */
-  }),
-  uploads: false,
-  playground: false,
   introspection: false,
   formatError: error => {
     logger.error(error)
     return error
   },
-  debug: devMode,
+  includeStacktraceInErrorResponses: devMode,
   logger
 })
+
+module.exports = { graphQLServer, context }

lib/graphql/types.js

@@ -1,4 +1,5 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
+
 module.exports = gql`
 type Coin {
   cryptoCode: String!

lib/machine-loader.js

@@ -13,7 +13,7 @@ const dbm = require('./postgresql_interface')
 const configManager = require('./new-config-manager')
 const notifierUtils = require('./notifier/utils')
 const notifierQueries = require('./notifier/queries')
-const { ApolloError } = require('apollo-server-errors');
+const { GraphQLError } = require('graphql');
 const { loadLatestConfig } = require('./new-settings-loader')
 const logger = require('./logger')
 
@@ -154,7 +154,7 @@ function getMachine (machineId, config) {
   const sql = `${MACHINE_WITH_CALCULATED_FIELD_SQL} WHERE d.device_id = $1`
 
   const queryMachine = db.oneOrNone(sql, [machineId]).then(r => {
-    if (r === null) throw new ApolloError('Resource doesn\'t exist', 'NOT_FOUND')
+    if (r === null) throw new GraphQLError('Resource doesn\'t exist', { extensions: { code: 'NOT_FOUND' } })
     else return toMachineObject(r)
   })
 

lib/middlewares/populateDeviceId.js

@@ -1,8 +1,5 @@
-const _ = require('lodash/fp')
 const crypto = require('crypto')
 
-const logger = require('../logger')
-
 function sha256 (buf) {
   if (!buf) return null
   const hash = crypto.createHash('sha256')
@@ -12,10 +9,9 @@ function sha256 (buf) {
 }
 
 const populateDeviceId = function (req, res, next) {
-  const deviceId = _.isFunction(req.connection.getPeerCertificate)
-    ? sha256(req.connection.getPeerCertificate()?.raw)
-    : null
-
+  const peerCert = req.socket.getPeerCertificate ? req.socket.getPeerCertificate() : null
+  const deviceId = peerCert?.raw ? sha256(peerCert.raw) : null
+  
   if (!deviceId) return res.status(500).json({ error: 'Unable to find certificate' })
   req.deviceId = deviceId
   req.deviceTime = req.get('date')

lib/new-admin/admin-server.js

@@ -4,19 +4,23 @@ const path = require('path')
 const express = require('express')
 const https = require('https')
 const serveStatic = require('serve-static')
-const cors = require('cors')
 const helmet = require('helmet')
 const nocache = require('nocache')
 const cookieParser = require('cookie-parser')
-const { graphqlUploadExpress } = require('graphql-upload')
-const { ApolloServer } = require('apollo-server-express')
+const { ApolloServer } = require('@apollo/server')
+const { expressMiddleware } = require('@apollo/server/express4')
+const { ApolloServerPluginLandingPageDisabled } = require('@apollo/server/plugin/disabled')
+const { ApolloServerPluginLandingPageLocalDefault } = require('@apollo/server/plugin/landingPage/default')
+
+const { mergeResolvers } = require('@graphql-tools/merge')
+const { makeExecutableSchema } = require('@graphql-tools/schema')
 
 require('../environment-helper')
 const { asyncLocalStorage, defaultStore } = require('../async-storage')
 const logger = require('../logger')
 const exchange = require('../exchange')
 
-const { AuthDirective } = require('./graphql/directives')
+const { authDirectiveTransformer } = require('./graphql/directives')
 const { typeDefs, resolvers } = require('./graphql/schema')
 const findOperatorId = require('../middlewares/operatorId')
 const computeSchema = require('../compute-schema')
@@ -28,6 +32,7 @@ const devMode = require('minimist')(process.argv.slice(2)).dev
 const HOSTNAME = process.env.HOSTNAME
 const KEY_PATH = process.env.KEY_PATH
 const CERT_PATH = process.env.CERT_PATH
+const CA_PATH = process.env.CA_PATH
 const ID_PHOTO_CARD_DIR = process.env.ID_PHOTO_CARD_DIR
 const FRONT_CAMERA_DIR = process.env.FRONT_CAMERA_DIR
 const OPERATOR_DATA_DIR = process.env.OPERATOR_DATA_DIR
@@ -37,64 +42,79 @@ if (!HOSTNAME) {
   process.exit(1)
 }
 
-const app = express()
+const loadRoutes = async () => {
+  const app = express()
 
-app.use(helmet())
-app.use(compression())
-app.use(nocache())
-app.use(cookieParser())
-app.use(express.json())
-app.use(express.urlencoded({ extended: true })) // support encoded bodies
-app.use(express.static(path.resolve(__dirname, '..', '..', 'public')))
-app.use(cleanUserSessions(USER_SESSIONS_CLEAR_INTERVAL))
-app.use(computeSchema)
-app.use(findOperatorId)
-app.use(session)
-app.use(graphqlUploadExpress())
+  app.use(helmet())
+  app.use(compression())
+  app.use(nocache())
+  app.use(cookieParser())
+  app.use(express.json())
+  app.use(express.urlencoded({ extended: true })) // support encoded bodies
+  app.use(express.static(path.resolve(__dirname, '..', '..', 'public')))
+  app.use(cleanUserSessions(USER_SESSIONS_CLEAR_INTERVAL))
+  app.use(computeSchema)
+  app.use(findOperatorId)
+  app.use(session)
 
-const apolloServer = new ApolloServer({
-  typeDefs,
-  resolvers,
-  uploads: false,
-  schemaDirectives: {
-    auth: AuthDirective
-  },
-  playground: false,
-  introspection: false,
-  formatError: error => {
-    const exception = error?.extensions?.exception
-    logger.error(error, JSON.stringify(exception || {}))
-    return error
-  },
-  context: async (obj) => buildApolloContext(obj)
-})
+  // Dynamic import for graphql-upload since it's not a CommonJS module
+  const { default: graphqlUploadExpress } = await import('graphql-upload/graphqlUploadExpress.mjs')
+  const { default: GraphQLUpload } = await import('graphql-upload/GraphQLUpload.mjs')
 
-apolloServer.applyMiddleware({
-  app,
-  cors: {
-    credentials: true,
-    origin: devMode && 'https://localhost:3001'
-  }
-})
+  app.use(graphqlUploadExpress())
 
-// cors on app for /api/register endpoint.
-app.use(cors({ credentials: true, origin: devMode && 'https://localhost:3001' }))
+  const schema = makeExecutableSchema({
+    typeDefs,
+    resolvers: mergeResolvers(resolvers, { Upload: GraphQLUpload }),
+  })
+  const schemaWithDirectives = authDirectiveTransformer(schema)
 
-app.use('/id-card-photo', serveStatic(ID_PHOTO_CARD_DIR, { index: false }))
-app.use('/front-camera-photo', serveStatic(FRONT_CAMERA_DIR, { index: false }))
-app.use('/operator-data', serveStatic(OPERATOR_DATA_DIR, { index: false }))
+  const apolloServer = new ApolloServer({
+    schema: schemaWithDirectives,
+    csrfPrevention: false,
+    introspection: false,
+    formatError: (formattedError, error) => {
+      logger.error(error, JSON.stringify(error?.extensions || {}))
+      return formattedError
+    },
+    plugins: [
+      devMode 
+        ? ApolloServerPluginLandingPageLocalDefault() 
+        : ApolloServerPluginLandingPageDisabled()
+    ]
+  })
 
-// Everything not on graphql or api/register is redirected to the front-end
-app.get('*', (req, res) => res.sendFile(path.resolve(__dirname, '..', '..', 'public', 'index.html')))
+  await apolloServer.start();
+
+  app.use(
+    '/graphql',
+    express.json(),
+    expressMiddleware(apolloServer, {
+      context: async ({ req, res }) => buildApolloContext({ req, res })
+    })
+  );
+
+
+  app.use('/id-card-photo', serveStatic(ID_PHOTO_CARD_DIR, { index: false }))
+  app.use('/front-camera-photo', serveStatic(FRONT_CAMERA_DIR, { index: false }))
+  app.use('/operator-data', serveStatic(OPERATOR_DATA_DIR, { index: false }))
+
+  // Everything not on graphql or api/register is redirected to the front-end
+  app.get('*', (req, res) => res.sendFile(path.resolve(__dirname, '..', '..', 'public', 'index.html')))
+
+  return app
+}
 
 const certOptions = {
   key: fs.readFileSync(KEY_PATH),
-  cert: fs.readFileSync(CERT_PATH)
+  cert: fs.readFileSync(CERT_PATH),
+  ca: fs.readFileSync(CA_PATH)
 }
 
 function run () {
   const store = defaultStore()
-  asyncLocalStorage.run(store, () => {
+  asyncLocalStorage.run(store, async () => {
+    const app = await loadRoutes()
     const serverPort = devMode ? 8070 : 443
 
     const serverLog = `lamassu-admin-server listening on port ${serverPort}`

lib/new-admin/graphql-dev-insecure.js

@@ -1,24 +0,0 @@
-const express = require('express')
-const { ApolloServer } = require('apollo-server-express')
-
-require('../environment-helper')
-const { typeDefs, resolvers } = require('./graphql/schema')
-const logger = require('../logger')
-
-const app = express()
-const server = new ApolloServer({
-  typeDefs,
-  resolvers
-})
-
-server.applyMiddleware({ app })
-
-app.use(express.json())
-
-function run () {
-  const serverLog = `lamassu-admin-server listening on port ${9010}${server.graphqlPath}`
-
-  app.listen(9010, () => logger.info(serverLog))
-}
-
-module.exports = { run }

lib/new-admin/graphql/directives/auth.js

@@ -1,40 +1,49 @@
 const _ = require('lodash/fp')
-
-const { SchemaDirectiveVisitor, AuthenticationError } = require('apollo-server-express')
+const { mapSchema, getDirective, MapperKind } = require('@graphql-tools/utils')
 const { defaultFieldResolver } = require('graphql')
 
-class AuthDirective extends SchemaDirectiveVisitor {
-  visitObject (type) {
-    this.ensureFieldsWrapped(type)
-    type._requiredAuthRole = this.args.requires
-  }
+const { AuthenticationError } = require('../errors')
 
-  visitFieldDefinition (field, details) {
-    this.ensureFieldsWrapped(details.objectType)
-    field._requiredAuthRole = this.args.requires
-  }
-
-  ensureFieldsWrapped (objectType) {
-    if (objectType._authFieldsWrapped) return
-    objectType._authFieldsWrapped = true
-
-    const fields = objectType.getFields()
-
-    _.forEach(fieldName => {
-      const field = fields[fieldName]
-      const { resolve = defaultFieldResolver } = field
-
-      field.resolve = function (root, args, context, info) {
-        const requiredRoles = field._requiredAuthRole ? field._requiredAuthRole : objectType._requiredAuthRole
+function authDirectiveTransformer(schema, directiveName = 'auth') {
+  return mapSchema(schema, {
+    // For object types
+    [MapperKind.OBJECT_TYPE]: (objectType) => {
+      const directive = getDirective(schema, objectType, directiveName)?.[0]
+      if (directive) {
+        const requiredAuthRole = directive.requires
+        objectType._requiredAuthRole = requiredAuthRole
+      }
+      return objectType
+    },
+    
+    // For field definitions
+    [MapperKind.OBJECT_FIELD]: (fieldConfig, _fieldName, typeName) => {
+      const directive = getDirective(schema, fieldConfig, directiveName)?.[0]
+      if (directive) {
+        const requiredAuthRole = directive.requires
+        fieldConfig._requiredAuthRole = requiredAuthRole
+      }
+      
+      // Get the parent object type
+      const objectType = schema.getType(typeName)
+      
+      // Apply auth check to the field's resolver
+      const { resolve = defaultFieldResolver } = fieldConfig
+      fieldConfig.resolve = function (root, args, context, info) {
+        const requiredRoles = fieldConfig._requiredAuthRole || objectType._requiredAuthRole
         if (!requiredRoles) return resolve.apply(this, [root, args, context, info])
-
+        
         const user = context.req.session.user
-        if (!user || !_.includes(_.upperCase(user.role), requiredRoles)) throw new AuthenticationError('You do not have permission to access this resource!')
-
+        if (!user || !_.includes(_.upperCase(user.role), requiredRoles)) {
+          throw new AuthenticationError('You do not have permission to access this resource!')
+        }
+        
         return resolve.apply(this, [root, args, context, info])
       }
-    }, _.keys(fields))
-  }
+      
+      return fieldConfig
+    }
+  })
 }
 
-module.exports = AuthDirective
+module.exports = authDirectiveTransformer

lib/new-admin/graphql/directives/index.js

@@ -1,3 +1,3 @@
-const AuthDirective = require('./auth')
+const authDirectiveTransformer = require('./auth')
 
-module.exports = { AuthDirective }
+module.exports = { authDirectiveTransformer }

lib/new-admin/graphql/errors.js

@@ -0,0 +1,71 @@
+const { GraphQLError } = require('graphql')
+const { ApolloServerErrorCode } = require('@apollo/server/errors')
+
+class AuthenticationError extends GraphQLError {
+  constructor() {
+    super('Authentication failed', {
+      extensions: {
+        code: 'UNAUTHENTICATED'
+      }
+    })
+  }
+}
+
+class InvalidCredentialsError extends GraphQLError {
+  constructor() {
+    super('Invalid credentials', {
+      extensions: {
+        code: 'INVALID_CREDENTIALS'
+      }
+    })
+  }
+}
+
+class UserAlreadyExistsError extends GraphQLError {
+  constructor() {
+    super('User already exists', {
+      extensions: {
+        code: 'USER_ALREADY_EXISTS'
+      }
+    })
+  }
+}
+
+class InvalidTwoFactorError extends GraphQLError {
+  constructor() {
+    super('Invalid two-factor code', {
+      extensions: {
+        code: 'INVALID_TWO_FACTOR_CODE'
+      }
+    })
+  }
+}
+
+class InvalidUrlError extends GraphQLError {
+  constructor() {
+    super('Invalid URL token', {
+      extensions: {
+        code: 'INVALID_URL_TOKEN'
+      }
+    })
+  }
+}
+
+class UserInputError extends GraphQLError {
+  constructor() {
+    super('User input error', {
+      extensions: {
+        code: ApolloServerErrorCode.BAD_USER_INPUT
+      }
+    })
+  }
+}
+
+module.exports = {
+  AuthenticationError,
+  InvalidCredentialsError,
+  UserAlreadyExistsError,
+  InvalidTwoFactorError,
+  InvalidUrlError,
+  UserInputError
+}

lib/new-admin/graphql/errors/authentication.js

@@ -1,37 +0,0 @@
-const { ApolloError, AuthenticationError } = require('apollo-server-express')
-
-class InvalidCredentialsError extends ApolloError {
-  constructor(message) {
-    super(message, 'INVALID_CREDENTIALS')
-    Object.defineProperty(this, 'name', { value: 'InvalidCredentialsError' })
-  }
-}
-
-class UserAlreadyExistsError extends ApolloError {
-  constructor(message) {
-    super(message, 'USER_ALREADY_EXISTS')
-    Object.defineProperty(this, 'name', { value: 'UserAlreadyExistsError' })
-  }
-}
-
-class InvalidTwoFactorError extends ApolloError {
-  constructor(message) {
-    super(message, 'INVALID_TWO_FACTOR_CODE')
-    Object.defineProperty(this, 'name', { value: 'InvalidTwoFactorError' })
-  }
-}
-
-class InvalidUrlError extends ApolloError {
-  constructor(message) {
-    super(message, 'INVALID_URL_TOKEN')
-    Object.defineProperty(this, 'name', { value: 'InvalidUrlError' })
-  }
-}
-
-module.exports = {
-  AuthenticationError,
-  InvalidCredentialsError,
-  UserAlreadyExistsError,
-  InvalidTwoFactorError,
-  InvalidUrlError
-}

lib/new-admin/graphql/modules/userManagement.js

@@ -8,7 +8,7 @@ const loginHelper = require('../../services/login')
 const T = require('../../../time')
 const users = require('../../../users')
 const sessionManager = require('../../../session-manager')
-const authErrors = require('../errors/authentication')
+const authErrors = require('../errors')
 const credentials = require('../../../hardware-credentials')
 
 const REMEMBER_ME_AGE = 90 * T.day

lib/new-admin/graphql/resolvers/scalar.resolver.js

@@ -1,13 +1,9 @@
-const { GraphQLDateTime } = require('graphql-iso-date')
-const { GraphQLJSON, GraphQLJSONObject } = require('graphql-type-json')
-const { GraphQLUpload } = require('graphql-upload')
-GraphQLDateTime.name = 'Date'
+const { DateTimeISOResolver, JSONResolver, JSONObjectResolver } = require('graphql-scalars')
 
 const resolvers = {
-  JSON: GraphQLJSON,
-  JSONObject: GraphQLJSONObject,
-  Date: GraphQLDateTime,
-  UploadGQL: GraphQLUpload
+  JSON: JSONResolver,
+  JSONObject: JSONObjectResolver,
+  Date: DateTimeISOResolver
 }
 
 module.exports = resolvers

lib/new-admin/graphql/types/bill.type.js

@@ -1,4 +1,4 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
   type Bill {

lib/new-admin/graphql/types/blacklist.type.js

@@ -1,4 +1,4 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
   type Blacklist {

lib/new-admin/graphql/types/cashbox.type.js

@@ -1,4 +1,4 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
   type CashboxBatch {

lib/new-admin/graphql/types/config.type.js

@@ -1,4 +1,4 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
   type Country {

lib/new-admin/graphql/types/currency.type.js

@@ -1,4 +1,4 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
   type Currency {

lib/new-admin/graphql/types/customInfoRequests.type.js

@@ -1,4 +1,4 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
 

lib/new-admin/graphql/types/customer.type.js

@@ -1,4 +1,4 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
   type Customer {
@@ -6,7 +6,7 @@ const typeDef = gql`
     authorizedOverride: String
     daysSuspended: Int
     isSuspended: Boolean
-    newPhoto: UploadGQL
+    newPhoto: Upload
     photoType: String
     frontCameraPath: String
     frontCameraAt: Date
@@ -18,7 +18,7 @@ const typeDef = gql`
     idCardData: JSONObject
     idCardDataOverride: String
     idCardDataExpiration: Date
-    idCardPhoto: UploadGQL
+    idCardPhoto: Upload
     idCardPhotoPath: String
     idCardPhotoOverride: String
     idCardPhotoAt: Date
@@ -74,7 +74,7 @@ const typeDef = gql`
 
   input CustomerEdit {
     idCardData: JSONObject
-    idCardPhoto: UploadGQL
+    idCardPhoto: Upload
     usSsn: String
     subscriberInfo: JSONObject
   }
@@ -108,7 +108,7 @@ const typeDef = gql`
     removeCustomField(customerId: ID!, fieldId: ID!): Boolean @auth
     editCustomer(customerId: ID!, customerEdit: CustomerEdit): Customer @auth
     deleteEditedData(customerId: ID!, customerEdit: CustomerEdit): Customer @auth
-    replacePhoto(customerId: ID!, photoType: String, newPhoto: UploadGQL): Customer @auth
+    replacePhoto(customerId: ID!, photoType: String, newPhoto: Upload): Customer @auth
     createCustomerNote(customerId: ID!, title: String!, content: String!): Boolean @auth
     editCustomerNote(noteId: ID!, newContent: String!): Boolean @auth
     deleteCustomerNote(noteId: ID!): Boolean @auth

lib/new-admin/graphql/types/funding.type.js

@@ -1,4 +1,4 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
   type CoinFunds {

lib/new-admin/graphql/types/log.type.js

@@ -1,4 +1,4 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
   type MachineLog {

lib/new-admin/graphql/types/loyalty.type.js

@@ -1,4 +1,4 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
   type IndividualDiscount {

lib/new-admin/graphql/types/machine.type.js

@@ -1,4 +1,4 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
   type MachineStatus {

lib/new-admin/graphql/types/market.type.js

@@ -1,4 +1,4 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
   type Query {

lib/new-admin/graphql/types/notification.type.js

@@ -1,4 +1,4 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
   type Notification {

lib/new-admin/graphql/types/pairing.type.js

@@ -1,4 +1,4 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
   type Mutation {

lib/new-admin/graphql/types/rates.type.js

@@ -1,4 +1,4 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
   type Rate {

lib/new-admin/graphql/types/sanctions.type.js

@@ -1,4 +1,4 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
   type SanctionMatches {

lib/new-admin/graphql/types/scalar.type.js

@@ -1,10 +1,10 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
   scalar JSON
   scalar JSONObject
   scalar Date
-  scalar UploadGQL
+  scalar Upload
 `
 
 module.exports = typeDef

lib/new-admin/graphql/types/settings.type.js

@@ -1,4 +1,4 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
   type Query {

lib/new-admin/graphql/types/sms.type.js

@@ -1,4 +1,4 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
   type SMSNotice {

lib/new-admin/graphql/types/status.type.js

@@ -1,4 +1,4 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
   type ProcessStatus {

lib/new-admin/graphql/types/transaction.type.js

@@ -1,4 +1,4 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
   type Transaction {

lib/new-admin/graphql/types/version.type.js

@@ -1,4 +1,4 @@
-const { gql } = require('apollo-server-express')
+const gql = require('graphql-tag')
 
 const typeDef = gql`
   type Query {

lib/new-admin/middlewares/context.js

@@ -1,6 +1,7 @@
-const { AuthenticationError } = require('apollo-server-express')
 const users = require('../../users')
 
+const { AuthenticationError } = require('../graphql/errors')
+
 const buildApolloContext = async ({ req, res }) => {
   if (!req.session.user) return { req, res }
 

lib/new-admin/services/machines.js

@@ -1,5 +1,5 @@
 const machineLoader = require('../../machine-loader')
-const { UserInputError } = require('apollo-server-express')
+const { UserInputError } = require('../graphql/errors')
 
 function getMachine (machineId) {
   return machineLoader.getMachines()

lib/routes.js

@@ -1,5 +1,4 @@
 const express = require('express')
-const argv = require('minimist')(process.argv.slice(2))
 const compression = require('compression')
 const helmet = require('helmet')
 const morgan = require('morgan')
@@ -35,84 +34,97 @@ const verifyPromoCodeRoutes = require('./routes/verifyPromoCodeRoutes')
 const probeRoutes = require('./routes/probeLnRoutes')
 const failedQRScansRoutes = require('./routes/failedQRScans')
 
-const graphQLServer = require('./graphql/server')
+const { graphQLServer, context } = require('./graphql/server')
 
-const app = express()
+const { expressMiddleware } = require('@apollo/server/express4')
 
-const configRequiredRoutes = [
-  '/poll',
-  '/terms_conditions',
-  '/event',
-  '/phone_code',
-  '/customer',
-  '/tx',
-  '/verify_promo_code',
-  '/graphql'
-]
+const loadRoutes = async () => {
+  const app = express()
 
-// middleware setup
-app.use(addRWBytes())
-app.use(compression({ threshold: 500 }))
-app.use(helmet())
-app.use(nocache())
-app.use(express.json({ limit: '2mb' }))
+  const configRequiredRoutes = [
+    '/poll',
+    '/terms_conditions',
+    '/event',
+    '/phone_code',
+    '/customer',
+    '/tx',
+    '/verify_promo_code',
+    '/graphql'
+  ]
 
-morgan.token('bytesRead', (_req, res) => res.bytesRead)
-morgan.token('bytesWritten', (_req, res) => res.bytesWritten)
-app.use(morgan(':method :url :status :response-time ms -- :bytesRead/:bytesWritten B', { stream: logger.stream }))
+  // middleware setup
+  app.use(addRWBytes())
+  app.use(compression({ threshold: 500 }))
+  app.use(helmet())
+  app.use(nocache())
+  app.use(express.json({ limit: '2mb' }))
 
-app.use('/robots.txt', (req, res) => {
-  res.type('text/plain')
-  res.send("User-agent: *\nDisallow: /")
-})
+  morgan.token('bytesRead', (_req, res) => res.bytesRead)
+  morgan.token('bytesWritten', (_req, res) => res.bytesWritten)
+  app.use(morgan(':method :url :status :response-time ms -- :bytesRead/:bytesWritten B', { stream: logger.stream }))
 
-app.get('/', (req, res) => {
-  res.sendStatus(404)
-})
+  app.use('/robots.txt', (req, res) => {
+    res.type('text/plain')
+    res.send("User-agent: *\nDisallow: /")
+  })
 
-// app /pair and /ca routes
-app.use('/', pairingRoutes)
+  app.get('/', (req, res) => {
+    res.sendStatus(404)
+  })
 
-app.use(findOperatorId)
-app.use(populateDeviceId)
-app.use(computeSchema)
-app.use(authorize)
-app.use(configRequiredRoutes, populateSettings)
-app.use(filterOldRequests)
+  // app /pair and /ca routes
+  app.use('/', pairingRoutes)
 
-// other app routes
-app.use('/graphql', recordPing)
-app.use('/poll', pollingRoutes)
-app.use('/terms_conditions', termsAndConditionsRoutes)
-app.use('/state', stateRoutes)
-app.use('/cashbox', cashboxRoutes)
+  app.use(findOperatorId)
+  app.use(populateDeviceId)
+  app.use(computeSchema)
+  app.use(authorize)
+  app.use(configRequiredRoutes, populateSettings)
+  app.use(filterOldRequests)
 
-app.use('/network', performanceRoutes)
-app.use('/diagnostics', diagnosticsRoutes)
-app.use('/failedqrscans', failedQRScansRoutes)
+  // other app routes
+  app.use('/graphql', recordPing)
+  app.use('/poll', pollingRoutes)
+  app.use('/terms_conditions', termsAndConditionsRoutes)
+  app.use('/state', stateRoutes)
+  app.use('/cashbox', cashboxRoutes)
 
-app.use('/verify_user', verifyUserRoutes)
-app.use('/verify_transaction', verifyTxRoutes)
-app.use('/verify_promo_code', verifyPromoCodeRoutes)
+  app.use('/network', performanceRoutes)
+  app.use('/diagnostics', diagnosticsRoutes)
+  app.use('/failedqrscans', failedQRScansRoutes)
 
-// BACKWARDS_COMPATIBILITY 9.0
-// machines before 9.0 still use the phone_code route
-app.use('/phone_code', phoneCodeRoutes)
+  app.use('/verify_user', verifyUserRoutes)
+  app.use('/verify_transaction', verifyTxRoutes)
+  app.use('/verify_promo_code', verifyPromoCodeRoutes)
 
-app.use('/customer', customerRoutes)
+  // BACKWARDS_COMPATIBILITY 9.0
+  // machines before 9.0 still use the phone_code route
+  app.use('/phone_code', phoneCodeRoutes)
 
-app.use('/tx', txRoutes)
+  app.use('/customer', customerRoutes)
 
-app.use('/logs', logsRoutes)
-app.use('/units', unitsRoutes)
+  app.use('/tx', txRoutes)
 
-app.use('/probe', probeRoutes)
+  app.use('/logs', logsRoutes)
+  app.use('/units', unitsRoutes)
 
-graphQLServer.applyMiddleware({ app })
+  app.use('/probe', probeRoutes)
 
-app.use(errorHandler)
-app.use((req, res) => {
-  res.status(404).json({ error: 'No such route' })
-})
+  await graphQLServer.start()
+  app.use('/graphql',
+    express.json(),
+    expressMiddleware(graphQLServer, {
+      context,
+    }),
+  );
 
-module.exports = { app }
+  app.use(errorHandler)
+  app.use((req, res) => {
+    res.status(404).json({ error: 'No such route' })
+  })
+
+  return app
+}
+
+
+module.exports = { loadRoutes }

new-lamassu-admin/.tool-versions

@@ -1 +0,0 @@
-nodejs 22

new-lamassu-admin/shell.nix

@@ -1,20 +0,0 @@
-with import (fetchTarball {
-  name = "nixpkgs-194846768975b7ad2c4988bdb82572c00222c0d7";
-  url = https://github.com/NixOS/nixpkgs/archive/194846768975b7ad2c4988bdb82572c00222c0d7.tar.gz;
-  sha256 = "0snj72i9dm99jlnnmk8id8ffjnfg1k81lr7aw8d01kz3hdiraqil";
-}) {};
-
-
-stdenv.mkDerivation {
-    name = "node";
-    buildInputs = [
-      nodejs_22
-      openssl
-      python3
-      entr
-      yasm
-    ];
-    shellHook = ''
-        export PATH="$PWD/node_modules/.bin/:$PATH"
-    '';
-}

package.json

@@ -6,6 +6,7 @@
   "license": "./LICENSE",
   "author": "Lamassu (https://lamassu.is)",
   "dependencies": {
+    "@apollo/server": "^4.11.3",
     "@bitgo/sdk-api": "1.33.0",
     "@bitgo/sdk-coin-bch": "1.5.22",
     "@bitgo/sdk-coin-btc": "1.7.22",
@@ -14,7 +15,9 @@
     "@bitgo/sdk-coin-zec": "1.5.22",
     "@ethereumjs/common": "^2.6.4",
     "@ethereumjs/tx": "^3.5.1",
-    "@graphql-tools/merge": "^6.2.5",
+    "@graphql-tools/merge": "^9.0.22",
+    "@graphql-tools/schema": "^10.0.21",
+    "@graphql-tools/utils": "^10.8.4",
     "@haensl/subset-sum": "^3.0.5",
     "@lamassu/coins": "v1.6.1",
     "@simplewebauthn/server": "^3.0.0",
@@ -22,7 +25,6 @@
     "@vonage/server-client": "1.7.0",
     "@vonage/sms": "1.7.0",
     "@vonage/vetch": "1.5.0",
-    "apollo-server-express": "2.25.1",
     "argon2": "0.28.2",
     "axios": "0.21.1",
     "base-x": "3.0.9",
@@ -50,10 +52,10 @@
     "form-data": "^4.0.0",
     "futoin-hkdf": "^1.0.2",
     "got": "^7.1.0",
-    "graphql": "^15.5.0",
-    "graphql-iso-date": "^3.6.1",
-    "graphql-type-json": "^0.3.1",
-    "graphql-upload": "12.0.0",
+    "graphql": "^16.10.0",
+    "graphql-scalars": "^1.24.1",
+    "graphql-tag": "^2.12.6",
+    "graphql-upload": "^17.0.0",
     "helmet": "^3.8.1",
     "inquirer": "^5.2.0",
     "json2csv": "^5.0.3",
@@ -130,8 +132,7 @@
     "build-admin": "npm run build-admin:css && npm run build-admin:main && npm run build-admin:lamassu",
     "server": "nodemon bin/lamassu-server --mockScoring --logLevel silly",
     "admin-server": "nodemon bin/lamassu-admin-server --dev --logLevel silly",
-    "graphql-server": "nodemon bin/new-graphql-dev-insecure",
-    "watch": "concurrently \"npm:server\" \"npm:admin-server\" \"npm:graphql-server\"",
+    "watch": "concurrently \"npm:server\" \"npm:admin-server\"",
     "stress-test": "cd tests/stress/ && node index.js 50 -v"
   },
   "nodemonConfig": {

shell.nix

@@ -1,13 +1,13 @@
 with import (fetchTarball {
-  name = "8ad5e8";
-  url = https://github.com/NixOS/nixpkgs/archive/8ad5e8132c5dcf977e308e7bf5517cc6cc0bf7d8.tar.gz;
-  sha256 = "17v6wigks04x1d63a2wcd7cc4z9ca6qr0f4xvw1pdw83f8a3c0nj";
+  name = "nixpkgs-194846768975b7ad2c4988bdb82572c00222c0d7";
+  url = https://github.com/NixOS/nixpkgs/archive/194846768975b7ad2c4988bdb82572c00222c0d7.tar.gz;
+  sha256 = "0snj72i9dm99jlnnmk8id8ffjnfg1k81lr7aw8d01kz3hdiraqil";
 }) {};
 
 stdenv.mkDerivation {
     name = "node";
-        buildInputs = [
-        nodejs-14_x
+    buildInputs = [
+        nodejs_22
         python3
         openssl
         postgresql