Feat: crypto balance notifications saving in DB

Chore: add new column "detail" to transactions table migration

Feat: check if older notification is valid before sending new one

Feat: error saving to database

Fix: fix error when invalidating notification on
clearCryptoBalanceNotifications
Chre: code refactor in new-settings-loader for simplicity
Chore: refactor code on notifier and merge similar functions

lib/notifier/index.js

@@ -10,7 +10,7 @@ const customers = require('../customers')
 const utils = require('./utils')
 const emailFuncs = require('./email')
 const smsFuncs = require('./sms')
-const { STALE, STALE_STATE } = require('./codes')
+const { STALE, STALE_STATE, PING } = require('./codes')
 
 function buildMessage(alerts, notifications) {
   const smsEnabled = utils.isActive(notifications.sms)
@@ -43,6 +43,7 @@ function checkNotification(plugins) {
 
   return getAlerts(plugins)
     .then(alerts => {
+      errorAlertsNotify(alerts)
       const currentAlertFingerprint = utils.buildAlertFingerprint(
         alerts,
         notifications
@@ -75,9 +76,10 @@ function getAlerts(plugins) {
     plugins.checkBalances(),
     queries.machineEvents(),
     plugins.getMachineNames()
-  ]).then(([balances, events, devices]) =>
-    buildAlerts(checkPings(devices), balances, events, devices)
-  )
+  ]).then(([balances, events, devices]) => {
+    balancesNotify(balances)
+    return buildAlerts(checkPings(devices), balances, events, devices)
+  })
 }
 
 function buildAlerts(pings, balances, events, devices) {
@@ -220,7 +222,7 @@ const cashCassettesNotify = (cassettes, deviceId) => {
 
     if(cashOutEnabled) {
       // we only want to add this notification if there isn't one already set and unread in the database
-      Promise.all([queries.getUnreadCassetteNotifications(1), queries.getUnreadCassetteNotifications(2)]).then(res => {
+      Promise.all([queries.getUnreadCassetteNotifications(1, deviceId), queries.getUnreadCassetteNotifications(2, deviceId)]).then(res => {
         if(res[0].length === 0 && cassette1Count < cassette1Threshold) {
           console.log("Adding fiatBalance alert for cashbox 1 in database - count & threshold: ", cassette1Count, cassette1Threshold )
           queries.addCashCassetteWarning(1, deviceId)
@@ -234,6 +236,133 @@ const cashCassettesNotify = (cassettes, deviceId) => {
   })
 }
 
+
+/*
+  Notes for new "valid" column on notifications table:
+
+  - We only want to add a new notification if it is present in the high or low warning consts.
+  - Before we add the notification we need to see if there is no "valid" notification in the database.
+  - Since the poller runs every few seconds, if the user marks it as read, this code would add a new notification
+  immediately. This new column helps us decide if a new notification should be added.
+  - "Valid" is defaulted to "true". When the cryptobalance goes over the low threshold or under the high threshold,
+  the notification will be marked as invalid. This will allow a new one to be sent. If the cryptobalance never goes
+  into the middle of the high and low thresholds, the old, "read" notification will still be relevant so we won't add
+  a new one.
+*/
+
+const clearOldCryptoNotifications = (balances) => {
+  // get valid crypto notifications from DB
+  // if that notification doesn't exist in balances, then make it invalid on the DB
+  queries.getAllValidNotifications('cryptoBalance').then(res => {
+    const notifications = _.map(it => {
+      return {
+        cryptoCode: it.detail.split('_')[0],
+        code: it.detail.split('_').splice(1).join('_')
+      }
+    }, res)
+    _.forEach(notification => {
+      const idx = _.findIndex(balance => {
+        return balance.code === notification.code && balance.cryptoCode === notification.cryptoCode
+      }, balances)
+
+      if(idx !== -1) {
+        return
+      }
+      // if the notification doesn't exist in the new balances object, then it is outdated and is not valid anymore
+      queries.invalidateNotification(notification.id)
+    }, notifications)
+  })
+}
+
+const balancesNotify = (balances) => {
+  const highFilter = o => o.code === 'HIGH_CRYPTO_BALANCE'
+  const lowFilter = o => o.code === 'LOW_CRYPTO_BALANCE'
+  const highWarnings = _.filter(highFilter, balances)
+  const lowWarnings = _.filter(lowFilter, balances)
+
+  clearOldCryptoNotifications(balances)
+
+  highWarnings.forEach(warning => {
+    queries.getValidNotifications('cryptoBalance', `${warning.cryptoCode}_${warning.code}`).then(res => {
+      if (res.length > 0) {
+        return Promise.resolve()
+      }
+      console.log("Adding high balance alert for " + warning.cryptoCode + " - " + warning.fiatBalance.balance)
+      const balance = utils.formatCurrency(warning.fiatBalance.balance, warning.fiatCode)
+      queries.addCryptoBalanceWarning(`${warning.cryptoCode}_${warning.code}`, `High balance in ${warning.cryptoCode} [${balance}]`)
+    })
+  })
+  lowWarnings.forEach(warning => {
+    queries.getValidNotifications('cryptoBalance', `${warning.cryptoCode}_${warning.code}`).then(res => {
+      if (res.length > 0) {
+        return Promise.resolve()
+      }
+      console.log("Adding low balance alert for " + warning.cryptoCode + " - " + warning.fiatBalance.balance)
+      const balance = utils.formatCurrency(warning.fiatBalance.balance, warning.fiatCode)
+      queries.addCryptoBalanceWarning(`${warning.cryptoCode}_${warning.code}`, `Low balance in ${warning.cryptoCode} [${balance}]`)
+    })
+  })
+}
+
+const clearOldErrorNotifications = (alerts) => {
+  queries.getAllValidNotifications('error').then(res => {
+    _.forEach(notification => {
+      const idx = _.findIndex(alert => {
+        return alert.code === notification.detail.split('_')[0] && alert.deviceId === notification.device_id
+      }, alerts)
+      if(idx !== -1) {
+        return
+      }
+      // if the notification doesn't exist, then it is outdated and is not valid anymore
+      queries.invalidateNotification(notification.id)
+    }, res)
+  })
+}
+
+const errorAlertsNotify = (alertRec) => {
+  let alerts = []
+  _.keys(alertRec.devices).forEach(function (device) {
+    // embed device ID in each alert object inside the deviceAlerts array
+    alertRec.devices[device].deviceAlerts = _.map(alert => {
+      return {...alert, deviceId: device}
+    }, alertRec.devices[device].deviceAlerts)
+    // concat every array into one
+    alerts = _.concat(alerts, alertRec.devices[device].deviceAlerts)
+  })
+  
+  //    now that we have all the alerts, we want to add PING and STALE alerts to the DB
+  //    if there is a valid alert on the DB that doesn't exist on the new alerts array,
+  // that alert should be considered invalid
+  //    after that, for the alerts array, we have to see if there is a valid alert of 
+  // the sorts already on the DB
+  clearOldErrorNotifications(alerts)
+
+  _.forEach(alert => {
+    switch(alert.code) {
+      case PING:
+        return queries.getValidNotifications('error', PING, alert.deviceId).then(res => {
+          if(res.length > 0) {
+            return Promise.resolve()
+          }
+          console.log("Adding PING alert on database for " + alert.machineName)
+          const message = `Machine down`
+          queries.addErrorNotification(`${PING}_${alert.age ? alert.age : '-1'}`, message, alert.deviceId)
+        })
+      case STALE:
+        return queries.getValidNotifications('error', STALE, alert.deviceId).then(res => {
+          if(res.length > 0) {
+            return Promise.resolve()
+          }
+          console.log("Adding STALE alert on database for " + alert.machineName)
+          const message = `Machine is stuck on ${alert.state} screen`
+          queries.addErrorNotification(STALE, message, alert.deviceId)
+        })
+      default:
+        break
+    }
+  }, alerts)
+}
+
 module.exports = {
   transactionNotify,
   checkNotification,