Merge pull request #1757 from RafaelTaranto/backport/hide-secrets-from-request

LAM-1243 fix: correctly hide secret fields from GQL results

lib/new-settings-loader.js

@@ -100,16 +100,19 @@ function loadAccounts (schemaVersion) {
     .then(_.compose(_.defaultTo({}), _.get('data.accounts')))
 }
 
+function hideSecretFields (accounts) {
+  return _.flow(
+    _.filter(path => !_.isEmpty(_.get(path, accounts))),
+    _.reduce(
+      (accounts, path) => _.assoc(path, PASSWORD_FILLED, accounts),
+      accounts
+    )
+  )(SECRET_FIELDS)
+}
+
 function showAccounts (schemaVersion) {
   return loadAccounts(schemaVersion)
-    .then(accounts => {
+    .then(hideSecretFields)
-      const filledSecretPaths = _.compact(_.map(path => {
-        if (!_.isEmpty(_.get(path, accounts))) {
-          return path
-        }
-      }, SECRET_FIELDS))
-      return _.compose(_.map(path => _.assoc(path, PASSWORD_FILLED), filledSecretPaths))(accounts)
-    })
 }
 
 const insertConfigRow = (dbOrTx, data) =>