From e103bc2f122070abe2cc7be28fbb8cac2a15c55e Mon Sep 17 00:00:00 2001
From: siiky <github-siiky@net-c.cat>
Date: Wed, 25 Jun 2025 12:15:19 +0100
Subject: [PATCH 1/5] refactor: there's a single transactions array now

And avoids a possible (though rare) crash...?
---
 .../Dashboard/SystemPerformance/SystemPerformance.jsx | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/packages/admin-ui/src/pages/Dashboard/SystemPerformance/SystemPerformance.jsx b/packages/admin-ui/src/pages/Dashboard/SystemPerformance/SystemPerformance.jsx
index c8017452..59603d4f 100644
--- a/packages/admin-ui/src/pages/Dashboard/SystemPerformance/SystemPerformance.jsx
+++ b/packages/admin-ui/src/pages/Dashboard/SystemPerformance/SystemPerformance.jsx
@@ -62,6 +62,7 @@ const SystemPerformance = () => {
   })
   const fiatLocale = fromNamespace('locale')(data?.config).fiatCurrency
   const timezone = fromNamespace('locale')(data?.config).timezone
+  const allTransactions = data?.transactions ?? []
 
   const NOW = Date.now()
 
@@ -113,10 +114,10 @@ const SystemPerformance = () => {
   }
 
   const transactionsToShow = R.map(convertFiatToLocale)(
-    R.filter(isInRangeAndNoError(false), data?.transactions ?? []),
+    R.filter(isInRangeAndNoError(false), allTransactions),
   )
   const transactionsLastTimePeriod = R.map(convertFiatToLocale)(
-    R.filter(isInRangeAndNoError(true), data?.transactions ?? []),
+    R.filter(isInRangeAndNoError(true), allTransactions),
   )
 
   const getNumTransactions = () => {
@@ -182,16 +183,16 @@ const SystemPerformance = () => {
   return (
     <>
       <Nav
-        showPicker={!loading && !R.isEmpty(data.transactions)}
+        showPicker={!loading && !R.isEmpty(allTransactions)}
         handleSetRange={setSelectedRange}
       />
-      {!loading && R.isEmpty(data.transactions) && (
+      {!loading && R.isEmpty(allTransactions) && (
         <EmptyTable
           className="pt-10"
           message="No transactions during the last month"
         />
       )}
-      {!loading && !R.isEmpty(data.transactions) && (
+      {!loading && !R.isEmpty(allTransactions) && (
         <div className="flex flex-col gap-12">
           <div className="flex gap-16">
             <InfoWithLabel info={getNumTransactions()} label={'transactions'} />

From 4b723476bc769ccc6b133a489b55006d018fde7c Mon Sep 17 00:00:00 2001
From: siiky <github-siiky@net-c.cat>
Date: Wed, 25 Jun 2025 11:37:32 +0100
Subject: [PATCH 2/5] chore: remove true clause from return expressions

It is already checked at the top of the function.
---
 .../Dashboard/SystemPerformance/SystemPerformance.jsx      | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/packages/admin-ui/src/pages/Dashboard/SystemPerformance/SystemPerformance.jsx b/packages/admin-ui/src/pages/Dashboard/SystemPerformance/SystemPerformance.jsx
index 59603d4f..a1f4ad4f 100644
--- a/packages/admin-ui/src/pages/Dashboard/SystemPerformance/SystemPerformance.jsx
+++ b/packages/admin-ui/src/pages/Dashboard/SystemPerformance/SystemPerformance.jsx
@@ -83,17 +83,12 @@ const SystemPerformance = () => {
     if (getLastTimePeriod) {
       const duration = rangeEnd - rangeStart
       return (
-        t.error === null &&
         createdTimestamp >= rangeStart - duration &&
         createdTimestamp < rangeStart
       )
     }
 
-    return (
-      t.error === null &&
-      createdTimestamp >= rangeStart &&
-      createdTimestamp <= rangeEnd
-    )
+    return createdTimestamp >= rangeStart && createdTimestamp <= rangeEnd
   }
 
   const convertFiatToLocale = item => {

From 6e8e784dc88a2a38258486a482cdf64fea107f59 Mon Sep 17 00:00:00 2001
From: siiky <github-siiky@net-c.cat>
Date: Wed, 25 Jun 2025 11:52:21 +0100
Subject: [PATCH 3/5] refactor: use BN arithmetic inside sum

Converting to BN after summing all the floats gives no advantage, the
damage is done.
---
 .../SystemPerformance/Graphs/RefLineChart.jsx |  2 +-
 .../SystemPerformance/SystemPerformance.jsx   | 27 +++++++++----------
 2 files changed, 13 insertions(+), 16 deletions(-)

diff --git a/packages/admin-ui/src/pages/Dashboard/SystemPerformance/Graphs/RefLineChart.jsx b/packages/admin-ui/src/pages/Dashboard/SystemPerformance/Graphs/RefLineChart.jsx
index 1d5808e7..b3790db1 100644
--- a/packages/admin-ui/src/pages/Dashboard/SystemPerformance/Graphs/RefLineChart.jsx
+++ b/packages/admin-ui/src/pages/Dashboard/SystemPerformance/Graphs/RefLineChart.jsx
@@ -2,7 +2,7 @@ import * as d3 from 'd3'
 import * as R from 'ramda'
 import React, { useEffect, useRef, useCallback } from 'react'
 
-const transactionProfit = R.prop('profit')
+const transactionProfit = tx => tx.profit.toNumber()
 
 const mockPoint = (tx, offsetMs, profit) => {
   const date = new Date(new Date(tx.created).getTime() + offsetMs).toISOString()
diff --git a/packages/admin-ui/src/pages/Dashboard/SystemPerformance/SystemPerformance.jsx b/packages/admin-ui/src/pages/Dashboard/SystemPerformance/SystemPerformance.jsx
index a1f4ad4f..18d714e3 100644
--- a/packages/admin-ui/src/pages/Dashboard/SystemPerformance/SystemPerformance.jsx
+++ b/packages/admin-ui/src/pages/Dashboard/SystemPerformance/SystemPerformance.jsx
@@ -22,7 +22,10 @@ import Nav from './Nav'
 
 BigNumber.config({ ROUNDING_MODE: BigNumber.ROUND_HALF_UP })
 
-const getFiats = R.map(R.prop('fiat'))
+const sumBNBy = by =>
+  R.reduce((acc, value) => acc.plus(by(value)), new BigNumber(0))
+
+const getProfit = sumBNBy(tx => tx.profit)
 
 const GET_DATA = gql`
   query getData($excludeTestingCustomers: Boolean, $from: DateTimeISO) {
@@ -95,16 +98,16 @@ const SystemPerformance = () => {
     if (item.fiatCode === fiatLocale)
       return {
         ...item,
-        fiat: parseFloat(item.fiat),
-        profit: parseFloat(item.profit),
+        fiat: new BigNumber(item.fiat),
+        profit: new BigNumber(item.profit),
       }
     const itemRate = R.find(R.propEq(item.fiatCode, 'code'))(data.fiatRates)
     const localeRate = R.find(R.propEq(fiatLocale, 'code'))(data.fiatRates)
     const multiplier = localeRate.rate / itemRate.rate
     return {
       ...item,
-      fiat: parseFloat(item.fiat) * multiplier,
-      profit: parseFloat(item.profit) * multiplier,
+      fiat: new BigNumber(item.fiat).times(multiplier),
+      profit: new BigNumber(item.profit).times(multiplier),
     }
   }
 
@@ -120,15 +123,7 @@ const SystemPerformance = () => {
   }
 
   const getFiatVolume = () =>
-    new BigNumber(R.sum(getFiats(transactionsToShow))).toFormat(2)
-
-  const getProfit = transactions => {
-    return R.reduce(
-      (acc, value) => acc.plus(value.profit),
-      new BigNumber(0),
-      transactions,
-    )
-  }
+    sumBNBy(tx => tx.fiat)(transactionsToShow).toFormat(2)
 
   const getPercentChange = () => {
     const thisTimePeriodProfit = getProfit(transactionsToShow)
@@ -251,7 +246,9 @@ const SystemPerformance = () => {
                 timeFrame={selectedRange}
                 data={transactionsToShow}
                 previousTimeData={transactionsLastTimePeriod}
-                previousProfit={getProfit(transactionsLastTimePeriod)}
+                previousProfit={getProfit(
+                  transactionsLastTimePeriod,
+                ).toNumber()}
               />
             </div>
             <div className="flex-1">

From 0de4fcce93996e16485b512497351c06ab39e243 Mon Sep 17 00:00:00 2001
From: siiky <github-siiky@net-c.cat>
Date: Wed, 25 Jun 2025 12:24:55 +0100
Subject: [PATCH 4/5] refactor: don't recompute direction percentages

---
 .../pages/Dashboard/SystemPerformance/SystemPerformance.jsx  | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/packages/admin-ui/src/pages/Dashboard/SystemPerformance/SystemPerformance.jsx b/packages/admin-ui/src/pages/Dashboard/SystemPerformance/SystemPerformance.jsx
index 18d714e3..95f763cd 100644
--- a/packages/admin-ui/src/pages/Dashboard/SystemPerformance/SystemPerformance.jsx
+++ b/packages/admin-ui/src/pages/Dashboard/SystemPerformance/SystemPerformance.jsx
@@ -273,10 +273,7 @@ const SystemPerformance = () => {
                   </div>
                 </div>
               </div>
-              <PercentageChart
-                cashIn={getDirectionPercent().cashIn}
-                cashOut={getDirectionPercent().cashOut}
-              />
+              <PercentageChart {...getDirectionPercent()} />
             </div>
           </div>
         </div>

From 8336c36d28ea4666f54aca8f50ca52efc52234de Mon Sep 17 00:00:00 2001
From: siiky <github-siiky@net-c.cat>
Date: Wed, 25 Jun 2025 12:25:59 +0100
Subject: [PATCH 5/5] refactor: DRY

---
 .../SystemPerformance/SystemPerformance.jsx         | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/packages/admin-ui/src/pages/Dashboard/SystemPerformance/SystemPerformance.jsx b/packages/admin-ui/src/pages/Dashboard/SystemPerformance/SystemPerformance.jsx
index 95f763cd..334b7817 100644
--- a/packages/admin-ui/src/pages/Dashboard/SystemPerformance/SystemPerformance.jsx
+++ b/packages/admin-ui/src/pages/Dashboard/SystemPerformance/SystemPerformance.jsx
@@ -111,12 +111,13 @@ const SystemPerformance = () => {
     }
   }
 
-  const transactionsToShow = R.map(convertFiatToLocale)(
-    R.filter(isInRangeAndNoError(false), allTransactions),
-  )
-  const transactionsLastTimePeriod = R.map(convertFiatToLocale)(
-    R.filter(isInRangeAndNoError(true), allTransactions),
-  )
+  const prepareTransactions = getLastTimePeriod =>
+    allTransactions
+      .filter(isInRangeAndNoError(getLastTimePeriod))
+      .map(convertFiatToLocale)
+
+  const transactionsToShow = prepareTransactions(false)
+  const transactionsLastTimePeriod = prepareTransactions(true)
 
   const getNumTransactions = () => {
     return R.length(transactionsToShow)