fix: review

This commit is contained in:
Sérgio Salgado 2021-01-07 10:43:16 +00:00 committed by Josh Harvey
parent 772805269f
commit 5045821593
9 changed files with 62 additions and 172 deletions

View file

@ -25,8 +25,9 @@ const E = require('./error')
const customers = require('./customers')
const logs = require('./logs')
const compliance = require('./compliance')
const couponManager = require('./coupon-manager')
const couponManager = require('./coupons')
const BN = require('./bn')
const commissionMath = require('./commission-math')
const version = require('../package.json').version
@ -223,7 +224,7 @@ function verifyCoupon (req, res, next) {
const transaction = req.body.tx
const commissions = configManager.getCommissions(transaction.cryptoCode, req.deviceId, req.settings.config)
const tickerRate = BN(transaction.rawTickerPrice)
const discount = getDiscountRate(coupon.discount, commissions[transaction.direction])
const discount = commissionMath.getDiscountRate(coupon.discount, commissions[transaction.direction])
const rates = {
[transaction.cryptoCode]: {
[transaction.direction]: (transaction.direction === 'cashIn')
@ -240,12 +241,6 @@ function verifyCoupon (req, res, next) {
.catch(next)
}
function getDiscountRate (discount, commission) {
const percentageDiscount = BN(1).sub(BN(discount).div(100))
const percentageCommission = BN(commission).div(100)
return BN(1).add(percentageDiscount.mul(percentageCommission))
}
function addOrUpdateCustomer (req) {
const customerData = req.body
const machineVersion = req.query.version