From 5b502c13955a54d991f670a6364aaac9716e1c38 Mon Sep 17 00:00:00 2001
From: Liordino Neto <liordinoneto@gmail.com>
Date: Sun, 1 Nov 2020 12:14:02 -0300
Subject: [PATCH] fix: high value notifications, if configured, are now
 triggered even if transactions notifications are globally disabled (for sms
 or email)

fix: added extra information on the sms notification informing if the
transaction that just happened is a high value one
---
 lib/plugins.js | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/lib/plugins.js b/lib/plugins.js
index 9953008f..c71de457 100644
--- a/lib/plugins.js
+++ b/lib/plugins.js
@@ -355,7 +355,7 @@ function plugins (settings, deviceId) {
     const notificationsEnabled = notifications.sms.transactions || notifications.email.transactions
     const highValueTx = tx.fiat.gt(notifications.highValueTransaction || Infinity)
 
-    if (!notificationsEnabled || !highValueTx) return Promise.resolve()
+    if (!notificationsEnabled && !highValueTx) return Promise.resolve()
 
     const isCashOut = tx.direction === 'cashOut'
     const zeroConf = isCashOut && isZeroConf(tx)
@@ -393,9 +393,9 @@ function plugins (settings, deviceId) {
         - Customer: ${customerName}
         ${phone}
       `
-        const subject = `A transaction just happened`
+        const subject = `A ${highValueTx ? 'high value ' : ''}transaction just happened`
 
-        return {
+        return [{
           sms: {
             body: `${subject} - ${status}`
           },
@@ -403,9 +403,9 @@ function plugins (settings, deviceId) {
             subject,
             body
           }
-        }
+        }, highValueTx]
       })
-      .then(sendTransactionMessage)
+      .then(([rec, highValueTx]) => sendTransactionMessage(rec, highValueTx))
   }
 
   function sendRedemptionMessage (txId, error) {
@@ -611,15 +611,15 @@ function plugins (settings, deviceId) {
     return Promise.all(promises)
   }
 
-  function sendTransactionMessage (rec) {
+  function sendTransactionMessage (rec, isHighValueTx) {
     const notifications = configManager.getGlobalNotifications(settings.config)
 
     let promises = []
 
-    const emailActive = notifications.email.active && notifications.email.transactions
+    const emailActive = notifications.email.active && (notifications.email.transactions || isHighValueTx)
     if (emailActive) promises.push(email.sendMessage(settings, rec))
 
-    const smsActive = notifications.sms.active && notifications.sms.transactions
+    const smsActive = notifications.sms.active && (notifications.sms.transactions || isHighValueTx)
     if (smsActive) promises.push(sms.sendMessage(settings, rec))
 
     return Promise.all(promises)