From 5c39140ea88a8511c4e5b3c7d14f5a405decc65c Mon Sep 17 00:00:00 2001 From: siiky Date: Fri, 25 Oct 2024 18:09:06 +0100 Subject: [PATCH] refactor: replace magic constants --- lib/constants.js | 2 ++ lib/plugins.js | 12 +++++++++--- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/lib/constants.js b/lib/constants.js index 60fcd128..07c2ad84 100644 --- a/lib/constants.js +++ b/lib/constants.js @@ -51,6 +51,7 @@ const CASH_UNIT_CAPACITY = { const CASH_OUT_MINIMUM_AMOUNT_OF_CASSETTES = 2 const CASH_OUT_MAXIMUM_AMOUNT_OF_CASSETTES = 4 +const CASH_OUT_MAXIMUM_AMOUNT_OF_RECYCLERS = 6 const AUTHENTICATOR_ISSUER_ENTITY = 'Lamassu' const AUTH_TOKEN_EXPIRATION_TIME = '30 minutes' const REGISTRATION_TOKEN_EXPIRATION_TIME = '30 minutes' @@ -85,6 +86,7 @@ module.exports = { CONFIRMATION_CODE, CASH_OUT_MINIMUM_AMOUNT_OF_CASSETTES, CASH_OUT_MAXIMUM_AMOUNT_OF_CASSETTES, + CASH_OUT_MAXIMUM_AMOUNT_OF_RECYCLERS, WALLET_SCORE_THRESHOLD, RECEIPT, PSQL_URL, diff --git a/lib/plugins.js b/lib/plugins.js index a97e1350..84a62cf8 100644 --- a/lib/plugins.js +++ b/lib/plugins.js @@ -24,7 +24,13 @@ const commissionMath = require('./commission-math') const loyalty = require('./loyalty') const transactionBatching = require('./tx-batching') -const { CASH_UNIT_CAPACITY, CASH_OUT_DISPENSE_READY, CONFIRMATION_CODE } = require('./constants') +const { + CASH_OUT_DISPENSE_READY, + CASH_OUT_MAXIMUM_AMOUNT_OF_CASSETTES, + CASH_OUT_MAXIMUM_AMOUNT_OF_RECYCLERS, + CASH_UNIT_CAPACITY, + CONFIRMATION_CODE, +} = require('./constants') const notifier = require('./notifier') @@ -703,7 +709,7 @@ function plugins (settings, deviceId) { return cashInAlerts const cassetteCapacity = getCashUnitCapacity(device.model, 'cassette') - const cassetteAlerts = Array(Math.min(device.numberOfCassettes ?? 0, 4)) + const cassetteAlerts = Array(Math.min(device.numberOfCassettes ?? 0, CASH_OUT_MAXIMUM_AMOUNT_OF_CASSETTES)) .fill(null) .flatMap((_elem, idx) => { const nth = idx + 1 @@ -726,7 +732,7 @@ function plugins (settings, deviceId) { }) const recyclerCapacity = getCashUnitCapacity(device.model, 'recycler') - const recyclerAlerts = Array(Math.min(device.numberOfRecyclers ?? 0, 6)) + const recyclerAlerts = Array(Math.min(device.numberOfRecyclers ?? 0, CASH_OUT_MAXIMUM_AMOUNT_OF_RECYCLERS)) .fill(null) .flatMap((_elem, idx) => { const nth = idx + 1