From 6537938ec3cc5fa4edce4362dc4d98ef3c2e4acc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Oliveira?= <josepfo.w@gmail.com>
Date: Mon, 28 Jun 2021 19:59:48 +0100
Subject: [PATCH] fix: remove unnecessary bn config and isBigNumber usage

---
 lib/bn.js                  |  9 ++-------
 lib/cash-in/cash-in-low.js | 11 ++++++-----
 2 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/lib/bn.js b/lib/bn.js
index b14298ad..77480082 100644
--- a/lib/bn.js
+++ b/lib/bn.js
@@ -1,10 +1,5 @@
 const BigNumber = require('bignumber.js')
 
-BigNumber.config({ROUNDING_MODE: BigNumber.ROUND_HALF_EVEN})
+BigNumber.config({ ROUNDING_MODE: BigNumber.ROUND_HALF_EVEN })
 
-function BN (s, radix) { return new BigNumber(s, radix) }
-
-BN.min = BigNumber.min
-BN.max = BigNumber.max
-
-module.exports = BN
+module.exports = BigNumber
diff --git a/lib/cash-in/cash-in-low.js b/lib/cash-in/cash-in-low.js
index 5dff32bf..79e726b5 100644
--- a/lib/cash-in/cash-in-low.js
+++ b/lib/cash-in/cash-in-low.js
@@ -20,9 +20,10 @@ const massageUpdates = _.flow(_.omit(massageUpdateFields),
 module.exports = {toObj, upsert, insert, update, massage, isClearToSend}
 
 function convertBigNumFields (obj) {
-  const convert = value => value && value._isBigNumber
-    ? value.toString()
-    : value
+  const convert = value =>
+    value && BN.isBigNumber(value)
+      ? value.toString()
+      : value
   return _.mapValues(convert, obj)
 }
 
@@ -113,7 +114,7 @@ function ensureRatchet (oldField, newField, fieldKey) {
   }
 
   if (_.isNil(newField)) return false
-  if (oldField.isBigNumber && newField.isBigNumber) return new BN(oldField).eq(newField)
+  if (BN.isBigNumber(oldField) && BN.isBigNumber(newField)) return new BN(oldField).eq(newField)
   if (oldField.toString() === newField.toString()) return true
 
   return false
@@ -122,7 +123,7 @@ function ensureRatchet (oldField, newField, fieldKey) {
 function isMonotonic (oldField, newField, fieldKey) {
   if (_.isNil(newField)) return false
   if (_.isBoolean(oldField)) return oldField === newField || !oldField
-  if (oldField.isBigNumber) return oldField.lte(newField)
+  if (BN.isBigNumber(oldField)) return oldField.lte(newField)
   if (_.isNumber(oldField)) return oldField <= newField
 
   throw new Error(`Unexpected value [${fieldKey}]: ${oldField}, ${newField}`)