lamassu/lamassu-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor: use BN arithmetic inside sum

Browse source 
Converting to BN after summing all the floats gives no advantage, the
damage is done.
This commit is contained in:
siiky 2025-06-25 11:52:21 +01:00
parent 4b723476bc
commit 6e8e784dc8
2 changed files with 13 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

2
packages/admin-ui/src/pages/Dashboard/SystemPerformance/Graphs/RefLineChart.jsx
View file

@ -2,7 +2,7 @@ import * as d3 from 'd3'
import * as R from 'ramda'
import React, { useEffect, useRef, useCallback } from 'react'
const transactionProfit = R.prop('profit')
const transactionProfit = tx => tx.profit.toNumber()
const mockPoint = (tx, offsetMs, profit) => {
const date = new Date(new Date(tx.created).getTime() + offsetMs).toISOString()

27
packages/admin-ui/src/pages/Dashboard/SystemPerformance/SystemPerformance.jsx
View file

@ -22,7 +22,10 @@ import Nav from './Nav'
BigNumber.config({ ROUNDING_MODE: BigNumber.ROUND_HALF_UP })
const getFiats = R.map(R.prop('fiat'))
const sumBNBy = by =>
R.reduce((acc, value) => acc.plus(by(value)), new BigNumber(0))
const getProfit = sumBNBy(tx => tx.profit)
const GET_DATA = gql`
query getData($excludeTestingCustomers: Boolean, $from: DateTimeISO) {
@ -95,16 +98,16 @@ const SystemPerformance = () => {
if (item.fiatCode === fiatLocale)
return {
...item,
fiat: parseFloat(item.fiat),
profit: parseFloat(item.profit),
fiat: new BigNumber(item.fiat),
profit: new BigNumber(item.profit),
}
const itemRate = R.find(R.propEq(item.fiatCode, 'code'))(data.fiatRates)
const localeRate = R.find(R.propEq(fiatLocale, 'code'))(data.fiatRates)
const multiplier = localeRate.rate / itemRate.rate
return {
...item,
fiat: parseFloat(item.fiat) * multiplier,
profit: parseFloat(item.profit) * multiplier,
fiat: new BigNumber(item.fiat).times(multiplier),
profit: new BigNumber(item.profit).times(multiplier),
}
}
@ -120,15 +123,7 @@ const SystemPerformance = () => {
}
const getFiatVolume = () =>
new BigNumber(R.sum(getFiats(transactionsToShow))).toFormat(2)
const getProfit = transactions => {
return R.reduce(
(acc, value) => acc.plus(value.profit),
new BigNumber(0),
transactions,
)
}
sumBNBy(tx => tx.fiat)(transactionsToShow).toFormat(2)
const getPercentChange = () => {
const thisTimePeriodProfit = getProfit(transactionsToShow)
@ -251,7 +246,9 @@ const SystemPerformance = () => {
timeFrame={selectedRange}
data={transactionsToShow}
previousTimeData={transactionsLastTimePeriod}
previousProfit={getProfit(transactionsLastTimePeriod)}
previousProfit={getProfit(
transactionsLastTimePeriod,
).toNumber()}
/>
</div>
<div className="flex-1">