fix: verify if wallet scoring is enabled

lib/cash-in/cash-in-tx.js

@@ -174,16 +174,20 @@ function doesTxReuseAddress (tx) {
 }
 
 function getWalletScore (tx, pi) {
-  if (!tx.fiat || tx.fiat.isZero()) {
+  pi.isWalletScoringEnabled(tx)
-    return pi.rateWallet(tx.cryptoCode, tx.toAddress)
+    .then(isEnabled => {
-  }
+      if(!isEnabled) return null
-  // Passthrough the previous result
+      if (!tx.fiat || tx.fiat.isZero()) {
-  return pi.isValidWalletScore(tx.walletScore)
+        return pi.rateWallet(tx.cryptoCode, tx.toAddress)
-    .then(isValid => ({
+      }
-      address: tx.toAddress,
+      // Passthrough the previous result
-      score: tx.walletScore,
+      return pi.isValidWalletScore(tx.walletScore)
-      isValid
+        .then(isValid => ({
-    }))
+          address: tx.toAddress,
+          score: tx.walletScore,
+          isValid
+        }))
+    })
 }
 
 function monitorPending (settings) {

lib/cash-out/cash-out-tx.js

@@ -122,30 +122,34 @@ function getWalletScore (tx, pi) {
     return tx
 
     // Transaction shows up on the blockchain, we can request the sender address
-  return pi.getTransactionHash(tx)
+  return pi.isWalletScoringEnabled(tx)
-    .then(rejectEmpty("No transaction hashes"))
+    .then(isEnabled => {
-    .then(txHashes => pi.getInputAddresses(tx, txHashes))
+      if (!isEnabled) return tx
-    .then(rejectEmpty("No input addresses"))
+      return pi.getTransactionHash(tx)
-    .then(addresses => Promise.all(_.map(it => pi.rateWallet(tx.cryptoCode, it), addresses)))
+        .then(rejectEmpty("No transaction hashes"))
-    .then(rejectEmpty("No score ratings"))
+        .then(txHashes => pi.getInputAddresses(tx, txHashes))
-    .then(_.maxBy(_.get(['score'])))
+        .then(rejectEmpty("No input addresses"))
-    .then(highestScore =>
+        .then(addresses => Promise.all(_.map(it => pi.rateWallet(tx.cryptoCode, it), addresses)))
-      // Conservatively assign the highest risk of all input addresses to the risk of this transaction
+        .then(rejectEmpty("No score ratings"))
-      highestScore.isValid
+        .then(_.maxBy(_.get(['score'])))
-        ? _.assign(tx, { walletScore: highestScore.score })
+        .then(highestScore =>
-        : _.assign(tx, {
+          // Conservatively assign the highest risk of all input addresses to the risk of this transaction
-          walletScore: highestScore.score,
+          highestScore.isValid
-          error: 'Address score is above defined threshold',
+            ? _.assign(tx, { walletScore: highestScore.score })
-          errorCode: 'scoreThresholdReached',
+            : _.assign(tx, {
+              walletScore: highestScore.score,
+              error: 'Address score is above defined threshold',
+              errorCode: 'scoreThresholdReached',
+              dispense: true
+            })
+        )
+        .catch(error => _.assign(tx, {
+          walletScore: 10,
+          error: `Failure getting address score: ${error.message}`,
+          errorCode: 'ciphertraceError',
           dispense: true
-        })
+        }))
-    )
+    })
-    .catch(error => _.assign(tx, {
-      walletScore: 10,
-      error: `Failure getting address score: ${error.message}`,
-      errorCode: 'ciphertraceError',
-      dispense: true
-    }))
 }
 
 function monitorLiveIncoming (settings) {

lib/plugins.js

@@ -850,6 +850,10 @@ function plugins (settings, deviceId) {
     return walletScoring.getInputAddresses(settings, tx.cryptoCode, txHashes)
   }
 
+  function isWalletScoringEnabled (tx) {
+    return walletScoring.isWalletScoringEnabled(settings, tx.cryptoCode)
+  }
+
   return {
     getRates,
     recordPing,
@@ -882,7 +886,8 @@ function plugins (settings, deviceId) {
     rateWallet,
     isValidWalletScore,
     getTransactionHash,
-    getInputAddresses
+    getInputAddresses,
+    isWalletScoringEnabled
   }
 }
 

lib/plugins/wallet-scoring/ciphertrace/ciphertrace.js

@@ -126,10 +126,19 @@ function getInputAddresses (account, cryptoCode, txHashes) {
     })
 }
 
+function isWalletScoringEnabled (account, cryptoCode) {
+  if (!SUPPORTED_COINS.includes(cryptoCode)) {
+    return Promise.reject(new Error('Unsupported crypto: ' + cryptoCode))
+  }
+
+  return Promise.resolve(!_.isNil(account) && account.enabled)
+}
+
 module.exports = {
   NAME,
   rateWallet,
   isValidWalletScore,
   getTransactionHash,
-  getInputAddresses
+  getInputAddresses,
+  isWalletScoringEnabled
 }

lib/plugins/wallet-scoring/mock-scoring/mock-scoring.js

@@ -36,10 +36,20 @@ function getInputAddresses (account, cryptoCode, txHashes) {
   })
 }
 
+function isWalletScoringEnabled (account, cryptoCode) {
+  return new Promise((resolve, _) => {
+    setTimeout(() => {
+      return resolve(true)
+    }, 100)
+  })
+}
+
+
 module.exports = {
   NAME,
   rateWallet,
   isValidWalletScore,
   getTransactionHash,
-  getInputAddresses
+  getInputAddresses,
+  isWalletScoringEnabled
 }

lib/wallet-scoring.js

@@ -47,9 +47,19 @@ function getInputAddresses (settings, cryptoCode, txHashes) {
     })
 }
 
+function isWalletScoringEnabled (settings, cryptoCode) {
+  return Promise.resolve()
+    .then(() => {
+      const { plugin, account } = loadWalletScoring(settings)
+
+      return plugin.isWalletScoringEnabled(account, cryptoCode)
+    })
+}
+
 module.exports = {
   rateWallet,
   isValidWalletScore,
   getTransactionHash,
-  getInputAddresses
+  getInputAddresses,
+  isWalletScoringEnabled
 }