lamassu/lamassu-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor: getErrorMsg() to pure functions

Browse source
This commit is contained in:
Sérgio Salgado 2021-04-20 22:07:57 +01:00 • committed by Josh Harvey
parent 26a051ff07
commit 86a245f6ba
4 changed files with 64 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

22
new-lamassu-admin/src/pages/UserManagement/modals/CreateUserModal.js
View file

@ -50,6 +50,14 @@ const radioOptions = [
}
]
const getErrorMsg = (formikErrors, formikTouched, mutationError) => {
if (!formikErrors || !formikTouched) return null
if (mutationError) return 'Internal server error'
if (formikErrors.username && formikTouched.username)
return formikErrors.username
return null
}
const CreateUserModal = ({ state, dispatch }) => {
const classes = useStyles()
@ -74,14 +82,6 @@ const CreateUserModal = ({ state, dispatch }) => {
[classes.error]: formikErrors.role && formikTouched.role
})
const getErrorMsg = (formikErrors, formikTouched) => {
if (!formikErrors || !formikTouched) return null
if (error) return 'Internal server error'
if (formikErrors.username && formikTouched.username)
return formikErrors.username
return null
}
return (
<>
{state.showCreateUserModal && !createUserURL && (
@ -125,8 +125,10 @@ const CreateUserModal = ({ state, dispatch }) => {
options={radioOptions}
/>
<div className={classes.footer}>
{getErrorMsg(errors, touched) && (
<ErrorMessage>{getErrorMsg(errors, touched)}</ErrorMessage>
{getErrorMsg(errors, touched, error) && (
<ErrorMessage>
{getErrorMsg(errors, touched, error)}
</ErrorMessage>
)}
<Button
type="submit"