lamassu/lamassu-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: ensure coin-change is valid before comparing with subset-sum

Browse source
This commit is contained in:
siiky 2025-02-03 14:34:19 +00:00
parent 8abbc792f6
commit 91c4ca4dce
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/bill-math.js
View file

@ -160,13 +160,13 @@ function makeChange(outCassettes, amount) {
const ss_solution = getSolution_old(outCassettes, amount, BILL_LIST_MODES.VALUE_ROUND_ROBIN) const ss_solution = getSolution_old(outCassettes, amount, BILL_LIST_MODES.VALUE_ROUND_ROBIN)
const cc_solution = getSolution(outCassettes, amount) const cc_solution = getSolution(outCassettes, amount)
if (!!ss_solution !== !!cc_solution) { if (!cc.check(cc_solution, amount.toNumber())) {
logger.error(new Error(`subset-sum and coin-change don't agree on solvability -- subset-sum:${!!ss_solution} coin-change:${!!cc_solution}`)) logger.error(new Error("coin-change provided a bad solution"))
return solutionToOriginalUnits(ss_solution, outCassettes) return solutionToOriginalUnits(ss_solution, outCassettes)
} }
if (!cc.check(cc_solution, amount.toNumber())) { if (!!ss_solution !== !!cc_solution) {
logger.error(new Error("coin-change provided a bad solution")) logger.error(new Error(`subset-sum and coin-change don't agree on solvability -- subset-sum:${!!ss_solution} coin-change:${!!cc_solution}`))
return solutionToOriginalUnits(ss_solution, outCassettes) return solutionToOriginalUnits(ss_solution, outCassettes)
} }