lamassu/lamassu-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor: reject empty/nil results

Browse source
This commit is contained in:
André Sá 2022-08-23 16:08:23 +01:00
parent bcbde40a52
commit 9784f21d64
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/cash-out/cash-out-tx.js
View file

@ -114,6 +114,7 @@ function processTxStatus (tx, settings) {
} }
function getWalletScore (tx, pi) { function getWalletScore (tx, pi) {
const rejectEmpty = message => x => _.isNil(x) || _.isEmpty(x) ? Promise.reject({ message }) : x
const statuses = ['published', 'authorized', 'confirmed'] const statuses = ['published', 'authorized', 'confirmed']
if (_.includes(tx.status, statuses) && _.isNil(tx.walletScore)) if (_.includes(tx.status, statuses) && _.isNil(tx.walletScore))
@ -121,12 +122,11 @@ function getWalletScore (tx, pi) {
// Transaction shows up on the blockchain, we can request the sender address // Transaction shows up on the blockchain, we can request the sender address
return pi.getTransactionHash(tx) return pi.getTransactionHash(tx)
.then(txHashes => _.isNil(txHashes) || _.isEmpty(txHashes) ? .then(rejectEmpty("No transaction hashes"))
Promise.reject({ message: "No transaction hashes" }) :
txHashes
)
.then(txHashes => pi.getInputAddresses(tx, txHashes)) .then(txHashes => pi.getInputAddresses(tx, txHashes))
.then(rejectEmpty("No input addresses"))
.then(addresses => Promise.all(_.map(it => pi.rateWallet(tx.cryptoCode, it), addresses))) .then(addresses => Promise.all(_.map(it => pi.rateWallet(tx.cryptoCode, it), addresses)))
.then(rejectEmpty("No score ratings"))
.then(_.maxBy(_.get(['score']))) .then(_.maxBy(_.get(['score'])))
.then(highestScore => .then(highestScore =>
// Conservatively assign the highest risk of all input addresses to the risk of this transaction // Conservatively assign the highest risk of all input addresses to the risk of this transaction