From 9f25c65bd57086a22c105b18797066391d2245f5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9rgio=20Salgado?= Date: Tue, 11 Oct 2022 17:30:04 +0100 Subject: [PATCH] fix: circular validation issue when editing a custom info request --- .../src/pages/Triggers/CustomInfoRequests/Wizard.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/new-lamassu-admin/src/pages/Triggers/CustomInfoRequests/Wizard.js b/new-lamassu-admin/src/pages/Triggers/CustomInfoRequests/Wizard.js index 51555e54..756ee865 100644 --- a/new-lamassu-admin/src/pages/Triggers/CustomInfoRequests/Wizard.js +++ b/new-lamassu-admin/src/pages/Triggers/CustomInfoRequests/Wizard.js @@ -173,7 +173,12 @@ const Wizard = ({ const classes = useStyles() const isEditing = !R.isNil(toBeEdited) const [step, setStep] = useState(isEditing ? 1 : 0) - const stepOptions = getStep(step, existingRequirements) + + // If we're editing, filter out the requirement being edited so that validation schemas don't enter in circular conflicts + const _existingRequirements = isEditing + ? R.filter(it => it.id !== toBeEdited.id, existingRequirements) + : existingRequirements + const stepOptions = getStep(step, _existingRequirements) const isLastStep = step === LAST_STEP const onContinue = (values, actions) => {