From a08e0fbbcc9da94dc12b197b027889ac4489cf1f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Oliveira?= <josepfo.w@gmail.com>
Date: Wed, 17 Feb 2021 14:58:34 +0000
Subject: [PATCH] feat: forms validate only on submit

---
 new-lamassu-admin/src/components/ConfirmDialog.js             | 1 -
 .../booleanPropertiesTable/BooleanPropertiesTable.js          | 2 ++
 new-lamassu-admin/src/components/editableTable/Table.js       | 4 ++++
 new-lamassu-admin/src/pages/AddMachine/AddMachine.js          | 2 ++
 new-lamassu-admin/src/pages/Blacklist/BlacklistModal.js       | 2 ++
 new-lamassu-admin/src/pages/Cashout/WizardStep.js             | 4 ++++
 new-lamassu-admin/src/pages/LoyaltyPanel/PromoCodesModal.js   | 2 ++
 .../Notifications/components/SingleFieldEditableNumber.js     | 2 ++
 .../src/pages/Notifications/sections/FiatBalanceAlerts.js     | 2 ++
 new-lamassu-admin/src/pages/OperatorInfo/ContactInfo.js       | 2 ++
 new-lamassu-admin/src/pages/OperatorInfo/TermsConditions.js   | 2 ++
 new-lamassu-admin/src/pages/Services/FormRenderer.js          | 2 ++
 new-lamassu-admin/src/pages/Triggers/Wizard.js                | 2 ++
 .../src/pages/Wizard/components/Wallet/ChooseCoin.js          | 2 ++
 14 files changed, 30 insertions(+), 1 deletion(-)

diff --git a/new-lamassu-admin/src/components/ConfirmDialog.js b/new-lamassu-admin/src/components/ConfirmDialog.js
index bab70a09..066e9f54 100644
--- a/new-lamassu-admin/src/components/ConfirmDialog.js
+++ b/new-lamassu-admin/src/components/ConfirmDialog.js
@@ -115,7 +115,6 @@ export const ConfirmDialog = memo(
             error={error}
             InputLabelProps={{ shrink: true }}
             onChange={handleChange}
-            onBlur={() => setError(isOnErrorState)}
           />
         </DialogContent>
         <DialogActions className={classes.dialogActions}>
diff --git a/new-lamassu-admin/src/components/booleanPropertiesTable/BooleanPropertiesTable.js b/new-lamassu-admin/src/components/booleanPropertiesTable/BooleanPropertiesTable.js
index 9ceb5a5e..7964643b 100644
--- a/new-lamassu-admin/src/components/booleanPropertiesTable/BooleanPropertiesTable.js
+++ b/new-lamassu-admin/src/components/booleanPropertiesTable/BooleanPropertiesTable.js
@@ -50,6 +50,8 @@ const BooleanPropertiesTable = memo(
     return (
       <div className={classes.booleanPropertiesTableWrapper}>
         <Formik
+          validateOnBlur={false}
+          validateOnChange={false}
           enableReinitialize
           onSubmit={innerSave}
           initialValues={initialValues}
diff --git a/new-lamassu-admin/src/components/editableTable/Table.js b/new-lamassu-admin/src/components/editableTable/Table.js
index f80793e4..8d7ee976 100644
--- a/new-lamassu-admin/src/components/editableTable/Table.js
+++ b/new-lamassu-admin/src/components/editableTable/Table.js
@@ -183,6 +183,8 @@ const ETable = ({
               <TBody>
                 {adding && (
                   <Formik
+                    validateOnBlur={false}
+                    validateOnChange={false}
                     initialValues={{ id: v4(), ...initialValues }}
                     onReset={onReset}
                     validationSchema={validationSchema}
@@ -205,6 +207,8 @@ const ETable = ({
 
                   return (
                     <Formik
+                      validateOnBlur={false}
+                      validateOnChange={false}
                       key={it.id ?? idx}
                       enableReinitialize
                       initialValues={it}
diff --git a/new-lamassu-admin/src/pages/AddMachine/AddMachine.js b/new-lamassu-admin/src/pages/AddMachine/AddMachine.js
index b72d771a..368a522f 100644
--- a/new-lamassu-admin/src/pages/AddMachine/AddMachine.js
+++ b/new-lamassu-admin/src/pages/AddMachine/AddMachine.js
@@ -131,6 +131,8 @@ const MachineNameComponent = ({ nextStep, classes, setQrCode, setName }) => {
         Machine Name (ex: Coffee shop 01)
       </Info2>
       <Formik
+        validateOnBlur={false}
+        validateOnChange={false}
         initialValues={initialValues}
         validationSchema={validationSchema}
         onSubmit={({ name }) => {
diff --git a/new-lamassu-admin/src/pages/Blacklist/BlacklistModal.js b/new-lamassu-admin/src/pages/Blacklist/BlacklistModal.js
index 55e0f6a6..1fc53d20 100644
--- a/new-lamassu-admin/src/pages/Blacklist/BlacklistModal.js
+++ b/new-lamassu-admin/src/pages/Blacklist/BlacklistModal.js
@@ -42,6 +42,8 @@ const BlackListModal = ({
       handleClose={onClose}
       open={true}>
       <Formik
+        validateOnBlur={false}
+        validateOnChange={false}
         initialValues={{
           address: ''
         }}
diff --git a/new-lamassu-admin/src/pages/Cashout/WizardStep.js b/new-lamassu-admin/src/pages/Cashout/WizardStep.js
index 8f26e9ff..4fe2a384 100644
--- a/new-lamassu-admin/src/pages/Cashout/WizardStep.js
+++ b/new-lamassu-admin/src/pages/Cashout/WizardStep.js
@@ -43,6 +43,8 @@ const WizardStep = ({
 
       {step <= 2 && (
         <Formik
+          validateOnBlur={false}
+          validateOnChange={false}
           onSubmit={onContinue}
           initialValues={{ top: '', bottom: '' }}
           enableReinitialize
@@ -95,6 +97,8 @@ const WizardStep = ({
 
       {step === 3 && (
         <Formik
+          validateOnBlur={false}
+          validateOnChange={false}
           onSubmit={onContinue}
           initialValues={{ zeroConfLimit: '' }}
           enableReinitialize
diff --git a/new-lamassu-admin/src/pages/LoyaltyPanel/PromoCodesModal.js b/new-lamassu-admin/src/pages/LoyaltyPanel/PromoCodesModal.js
index 63c47687..69702dcf 100644
--- a/new-lamassu-admin/src/pages/LoyaltyPanel/PromoCodesModal.js
+++ b/new-lamassu-admin/src/pages/LoyaltyPanel/PromoCodesModal.js
@@ -49,6 +49,8 @@ const PromoCodesModal = ({ showModal, onClose, errorMsg, addCode }) => {
           handleClose={onClose}
           open={true}>
           <Formik
+            validateOnBlur={false}
+            validateOnChange={false}
             initialValues={initialValues}
             validationSchema={validationSchema}
             onSubmit={({ code, discount }) => {
diff --git a/new-lamassu-admin/src/pages/Notifications/components/SingleFieldEditableNumber.js b/new-lamassu-admin/src/pages/Notifications/components/SingleFieldEditableNumber.js
index 10e43518..37bd9c12 100644
--- a/new-lamassu-admin/src/pages/Notifications/components/SingleFieldEditableNumber.js
+++ b/new-lamassu-admin/src/pages/Notifications/components/SingleFieldEditableNumber.js
@@ -53,6 +53,8 @@ const SingleFieldEditableNumber = ({
 
   return (
     <Formik
+      validateOnBlur={false}
+      validateOnChange={false}
       enableReinitialize
       initialValues={{ [name]: (data && data[name]) ?? '' }}
       validationSchema={schema}
diff --git a/new-lamassu-admin/src/pages/Notifications/sections/FiatBalanceAlerts.js b/new-lamassu-admin/src/pages/Notifications/sections/FiatBalanceAlerts.js
index 169ad29c..9fd38e51 100644
--- a/new-lamassu-admin/src/pages/Notifications/sections/FiatBalanceAlerts.js
+++ b/new-lamassu-admin/src/pages/Notifications/sections/FiatBalanceAlerts.js
@@ -53,6 +53,8 @@ const FiatBalance = ({
 
   return (
     <Formik
+      validateOnBlur={false}
+      validateOnChange={false}
       enableReinitialize
       initialValues={{
         fiatBalanceCassette1: data?.fiatBalanceCassette1 ?? '',
diff --git a/new-lamassu-admin/src/pages/OperatorInfo/ContactInfo.js b/new-lamassu-admin/src/pages/OperatorInfo/ContactInfo.js
index d1031281..f655c786 100644
--- a/new-lamassu-admin/src/pages/OperatorInfo/ContactInfo.js
+++ b/new-lamassu-admin/src/pages/OperatorInfo/ContactInfo.js
@@ -218,6 +218,8 @@ const ContactInfo = ({ wizard }) => {
           )}
         </div>
         <Formik
+          validateOnBlur={false}
+          validateOnChange={false}
           enableReinitialize
           initialValues={form.initialValues}
           validationSchema={validationSchema}
diff --git a/new-lamassu-admin/src/pages/OperatorInfo/TermsConditions.js b/new-lamassu-admin/src/pages/OperatorInfo/TermsConditions.js
index e221fd4f..ae7c663d 100644
--- a/new-lamassu-admin/src/pages/OperatorInfo/TermsConditions.js
+++ b/new-lamassu-admin/src/pages/OperatorInfo/TermsConditions.js
@@ -198,6 +198,8 @@ const TermsConditions = () => {
           )}
         </div>
         <Formik
+          validateOnBlur={false}
+          validateOnChange={false}
           enableReinitialize
           initialValues={initialValues}
           validationSchema={validationSchema}
diff --git a/new-lamassu-admin/src/pages/Services/FormRenderer.js b/new-lamassu-admin/src/pages/Services/FormRenderer.js
index c2eafe20..eef0acb0 100644
--- a/new-lamassu-admin/src/pages/Services/FormRenderer.js
+++ b/new-lamassu-admin/src/pages/Services/FormRenderer.js
@@ -42,6 +42,8 @@ const FormRenderer = ({
 
   return (
     <Formik
+      validateOnBlur={false}
+      validateOnChange={false}
       enableReinitialize
       initialValues={values}
       validationSchema={validationSchema}
diff --git a/new-lamassu-admin/src/pages/Triggers/Wizard.js b/new-lamassu-admin/src/pages/Triggers/Wizard.js
index e1870017..be00f656 100644
--- a/new-lamassu-admin/src/pages/Triggers/Wizard.js
+++ b/new-lamassu-admin/src/pages/Triggers/Wizard.js
@@ -235,6 +235,8 @@ const Wizard = ({ onClose, save, error, currency }) => {
           currentStep={step}
         />
         <Formik
+          validateOnBlur={false}
+          validateOnChange={false}
           enableReinitialize
           onSubmit={onContinue}
           initialValues={stepOptions.initialValues}
diff --git a/new-lamassu-admin/src/pages/Wizard/components/Wallet/ChooseCoin.js b/new-lamassu-admin/src/pages/Wizard/components/Wallet/ChooseCoin.js
index 63ffc978..d434720e 100644
--- a/new-lamassu-admin/src/pages/Wizard/components/Wallet/ChooseCoin.js
+++ b/new-lamassu-admin/src/pages/Wizard/components/Wallet/ChooseCoin.js
@@ -51,6 +51,8 @@ const ChooseCoin = ({ addData }) => {
       </H4>
 
       <Formik
+        validateOnBlur={false}
+        validateOnChange={false}
         enableReinitialize
         initialValues={{ coin: '' }}
         onSubmit={onSubmit}>