fix: no need to pointerEvents: none if svg have no name

fix: modified unrelated file
This commit is contained in:
Mauricio Navarro Miranda 2020-08-21 01:14:45 -05:00 committed by Josh Harvey
parent eb9acc32f2
commit a32aca40b2
7 changed files with 5 additions and 22 deletions

View file

@ -11,9 +11,6 @@ const useStyles = makeStyles({
marginTop: 4, marginTop: 4,
cursor: 'pointer' cursor: 'pointer'
}, },
preventDefaultTooltip: {
pointerEvents: 'none'
},
popoverContent: ({ width }) => ({ popoverContent: ({ width }) => ({
width, width,
padding: [[10, 15]] padding: [[10, 15]]
@ -53,9 +50,7 @@ const Tooltip = memo(
onPointerOver={event => enableOver && handleOpenHelpPopper(event)} onPointerOver={event => enableOver && handleOpenHelpPopper(event)}
onClick={event => enableClick && handleOpenHelpPopper(event)} onClick={event => enableClick && handleOpenHelpPopper(event)}
{...props}> {...props}>
{Button !== FeatureButton && ( {Button !== FeatureButton && <Icon></Icon>}
<Icon className={classes.preventDefaultTooltip}></Icon>
)}
</Button> </Button>
<Popper <Popper
open={helpPopperOpen} open={helpPopperOpen}

View file

@ -19,7 +19,7 @@ const ActionButton = memo(
<button className={classnames(classNames, className)} {...props}> <button className={classnames(classNames, className)} {...props}>
{Icon && ( {Icon && (
<div className={classes.actionButtonIcon}> <div className={classes.actionButtonIcon}>
<Icon className={classes.preventDefaultTooltip} /> <Icon />
</div> </div>
)} )}
{InverseIcon && ( {InverseIcon && (

View file

@ -23,9 +23,6 @@ const colors = (color1, color2, color3) => {
} }
export default { export default {
preventDefaultTooltip: {
pointerEvents: 'none'
},
actionButton: { actionButton: {
extend: p, extend: p,
cursor: 'pointer', cursor: 'pointer',

View file

@ -7,9 +7,6 @@ import baseButtonStyles from './BaseButton.styles'
const { baseButton, primary } = baseButtonStyles const { baseButton, primary } = baseButtonStyles
const styles = { const styles = {
preventDefaultTooltip: {
pointerEvents: 'none'
},
featureButton: { featureButton: {
extend: baseButton, extend: baseButton,
width: baseButton.height, width: baseButton.height,
@ -47,7 +44,7 @@ const FeatureButton = memo(
<button className={classnames(classNames, className)} {...props}> <button className={classnames(classNames, className)} {...props}>
{Icon && ( {Icon && (
<div className={classes.buttonIcon}> <div className={classes.buttonIcon}>
<Icon className={classes.preventDefaultTooltip} /> <Icon />
</div> </div>
)} )}
{InverseIcon && ( {InverseIcon && (

View file

@ -7,9 +7,6 @@ import baseButtonStyles from './BaseButton.styles'
const { baseButton, primary } = baseButtonStyles const { baseButton, primary } = baseButtonStyles
const styles = { const styles = {
preventDefaultTooltip: {
pointerEvents: 'none'
},
button: { button: {
extend: baseButton, extend: baseButton,
borderRadius: baseButton.height / 2, borderRadius: baseButton.height / 2,
@ -41,7 +38,7 @@ const SimpleButton = memo(
{...props}> {...props}>
{Icon && ( {Icon && (
<div className={classes.buttonIcon}> <div className={classes.buttonIcon}>
<Icon className={classes.preventDefaultTooltip} /> <Icon />
</div> </div>
)} )}
{InverseIcon && ( {InverseIcon && (

View file

@ -39,7 +39,7 @@ function Select({ label, items, ...props }) {
<label {...getLabelProps()}>{startCase(label)}</label> <label {...getLabelProps()}>{startCase(label)}</label>
<button {...getToggleButtonProps()}> <button {...getToggleButtonProps()}>
<span className={classes.selectedItem}>{startCase(selectedItem)}</span> <span className={classes.selectedItem}>{startCase(selectedItem)}</span>
<Arrowdown className={classes.preventDefaultTooltip} /> <Arrowdown />
</button> </button>
<ul {...getMenuProps()}> <ul {...getMenuProps()}>
{isOpen && {isOpen &&

View file

@ -6,9 +6,6 @@ const { p, label1 } = typographyStyles
const WIDTH = 152 const WIDTH = 152
export default { export default {
preventDefaultTooltip: {
pointerEvents: 'none'
},
selectedItem: { selectedItem: {
width: WIDTH - 41, width: WIDTH - 41,
display: 'block', display: 'block',