lamassu/lamassu-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1405 from chaotixkilla/fix-trigger-config-overrides-circular-validation

Browse source 
Fix circular validation when editing a trigger settings override
This commit is contained in:
Rafael Taranto 2022-10-13 13:26:57 +01:00 • committed by GitHub
commit ae34037f66
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
new-lamassu-admin/src/pages/Triggers/components/helper.js
View file

@ -47,8 +47,10 @@ const getOverridesSchema = (values, customInfoRequests) => {
.required()
.test({
test() {
const { requirement } = this.parent
if (R.find(R.propEq('requirement', requirement))(values)) {
const { id, requirement } = this.parent
// If we're editing, filter out the override being edited so that validation schemas don't enter in circular conflicts
const _values = R.filter(it => it.id !== id, values)
if (R.find(R.propEq('requirement', requirement))(_values)) {
return this.createError({
message: `Requirement ${displayRequirement(
requirement,