refactor: concat instead of push

new-lamassu-admin/src/pages/Notifications/sections/FiatBalanceOverrides.js

@@ -51,7 +51,7 @@ const FiatBalanceOverrides = ({ config, section }) => {
   const suggestions = suggestionFilter(machines)
 
   const findSuggestion = it => {
-    const coin = R.compose(R.find(R.propEq('deviceId', it?.machine)))(machines)
+    const coin = R.find(R.propEq('deviceId', it?.machine), machines)
     return coin ? [coin] : []
   }
 
@@ -130,37 +130,35 @@ const FiatBalanceOverrides = ({ config, section }) => {
   const viewMachine = it =>
     R.compose(R.path(['name']), R.find(R.propEq('deviceId', it)))(machines)
 
-  const elements = [
+  const elements = R.concat(
-    {
+    [
-      name: MACHINE_KEY,
+      {
-      width: widthsByNumberOfCassettes[maxNumberOfCassettes].machine,
+        name: MACHINE_KEY,
-      size: 'sm',
+        width: widthsByNumberOfCassettes[maxNumberOfCassettes].machine,
-      view: viewMachine,
+        size: 'sm',
-      input: Autocomplete,
+        view: viewMachine,
-      inputProps: {
+        input: Autocomplete,
-        options: it => R.concat(suggestions, findSuggestion(it)),
+        inputProps: {
-        valueProp: 'deviceId',
+          options: it => R.concat(suggestions, findSuggestion(it)),
-        labelProp: 'name'
+          valueProp: 'deviceId',
+          labelProp: 'name'
+        }
+      },
+      {
+        name: CASHBOX_KEY,
+        display: 'Cashbox',
+        width: 155,
+        textAlign: 'right',
+        bold: true,
+        input: NumberInput,
+        suffix: 'notes',
+        inputProps: {
+          decimalPlaces: 0
+        }
       }
-    },
+    ],
-    {
+    R.map(
-      name: CASHBOX_KEY,
+      it => ({
-      display: 'Cashbox',
-      width: 155,
-      textAlign: 'right',
-      bold: true,
-      input: NumberInput,
-      suffix: 'notes',
-      inputProps: {
-        decimalPlaces: 0
-      }
-    }
-  ]
-
-  R.until(
-    R.gt(R.__, maxNumberOfCassettes),
-    it => {
-      elements.push({
         name: `fillingPercentageCassette${it}`,
         display: `Cash cassette ${it}`,
         width: widthsByNumberOfCassettes[maxNumberOfCassettes].cassette,
@@ -172,15 +170,14 @@ const FiatBalanceOverrides = ({ config, section }) => {
         inputProps: {
           decimalPlaces: 0
         },
-        view: it => it?.toString() ?? '—',
+        view: el => el?.toString() ?? '—',
         isHidden: value =>
           it >
           machines.find(({ deviceId }) => deviceId === value.machine)
             ?.numberOfCassettes
-      })
+      }),
-      return R.add(1, it)
+      R.range(1, maxNumberOfCassettes + 1)
-    },
+    )
-    1
   )
 
   return (