chore: deprecate old migrations

migrations/1509439657189-add_machine_name_to_devices.js

@@ -1,25 +1,15 @@
 const db = require('./db')
-const migrateTools = require('./migrate-tools')
 
+// This migration was updated on v10.2
+// it's from before 7.5 and we update one major version at a time
+// Data migration was removed, keeping only the schema update
 exports.up = function (next) {
-  return migrateTools.migrateNames()
-    .then(updateSql => {
-      const sql = [
-        'alter table devices add column name text',
-        updateSql,
-        'alter table devices alter column name set not null'
-      ]
+  const sql = [
+    'alter table devices add column name text',
+    'alter table devices alter column name set not null'
+  ]
 
-      return db.multi(sql, next)
-    })
-    .catch(() => {
-      const sql = [
-        'alter table devices add column name text',
-        'alter table devices alter column name set not null'
-      ]
-
-      return db.multi(sql, next)
-    })
+  return db.multi(sql, next)
 }
 
 exports.down = function (next) {

migrations/1599523522436-migrate-config.js

@@ -1,34 +1,9 @@
-const db = require('./db')
-const machineLoader = require('../lib/machine-loader')
-const { migrationSaveConfig, saveAccounts, loadLatest } = require('../lib/new-settings-loader')
-const { migrate } = require('../lib/config-migration')
-
-const _ = require('lodash/fp')
-
-const OLD_SETTINGS_LOADER_SCHEMA_VERSION = 1
-
+// This migration was actually a config update
+// it's from before 7.5 and we update one major version at a time
+// v10.2 is good enough to deprecate it
+// file still has to exist so that the migration tool doesn't throw an error
 module.exports.up = function (next) {
-  function migrateConfig (settings) {
-    const newSettings = migrate(settings.config, settings.accounts)
-    return Promise.all([
-      migrationSaveConfig(newSettings.config),
-      saveAccounts(newSettings.accounts)
-    ])
-      .then(() => next())
-  }
-
-  loadLatest(OLD_SETTINGS_LOADER_SCHEMA_VERSION)
-    .then(settings => _.isEmpty(settings.config)
-        ? next()
-        : migrateConfig(settings)
-    )
-    .catch(err => {
-      if (err.message === 'lamassu-server is not configured') {
-        return next()
-      }
-      console.log(err.message)
-      return next(err)
-    })
+  next()
 }
 
 module.exports.down = function (next) {

migrations/migrate-tools.js

@@ -1,16 +0,0 @@
-const pgp = require('pg-promise')()
-const _ = require('lodash/fp')
-
-const settingsLoader = require('../lib/admin/settings-loader')
-const machineLoader = require('../lib/machine-loader')
-
-module.exports = {migrateNames}
-
-function migrateNames () {
-  const cs = new pgp.helpers.ColumnSet(['?device_id', 'name'], {table: 'devices'})
-
-  return settingsLoader.loadLatestConfig(false)
-    .then(config => machineLoader.getMachineNames(config))
-    .then(_.map(r => ({device_id: r.deviceId, name: r.name})))
-    .then(data => pgp.helpers.update(data, cs) + ' WHERE t.device_id=v.device_id')
-}