From cb046ea7268e35b44782cc015f43a3e266846957 Mon Sep 17 00:00:00 2001
From: siiky <github-siiky@net-c.cat>
Date: Tue, 3 Jun 2025 12:33:32 +0100
Subject: [PATCH] chore: drop `if` to idempotent op

---
 packages/server/lib/middlewares/populateSettings.js | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/packages/server/lib/middlewares/populateSettings.js b/packages/server/lib/middlewares/populateSettings.js
index 04f3f76d..8d6c9d0b 100644
--- a/packages/server/lib/middlewares/populateSettings.js
+++ b/packages/server/lib/middlewares/populateSettings.js
@@ -110,7 +110,7 @@ const populateSettings = function (req, res, next) {
 
     const operatorSettings = settingsCache.get(`${operatorId}-latest`)
 
-    if (!!needsSettingsReload[operatorId] || !operatorSettings) {
+    if (needsSettingsReload[operatorId] || !operatorSettings) {
       needsSettingsReload[operatorId]
         ? logger.debug(
             'Fetching and caching a new latest config value, as a reload was requested',
@@ -125,8 +125,7 @@ const populateSettings = function (req, res, next) {
           const versionId = settings.version
           settingsCache.set(`${operatorId}-latest`, settings)
           settingsCache.set(`${operatorId}-v${versionId}`, settings)
-          if (needsSettingsReload[operatorId])
-            delete needsSettingsReload[operatorId]
+          delete needsSettingsReload[operatorId]
           req.settings = settings
         })
         .then(() => next())