lamassu/lamassu-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor: drop getMachineName() from notifier

Browse source
This commit is contained in:
siiky 2024-02-14 14:46:23 +00:00
parent 374a4272a5
commit d2cdca701a
2 changed files with 5 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/notifier/index.js
View file

@ -13,6 +13,8 @@ const smsFuncs = require('./sms')
const webhookFuncs = require('./webhook') const webhookFuncs = require('./webhook')
const { STALE, STALE_STATE } = require('./codes') const { STALE, STALE_STATE } = require('./codes')
const { getMachineName } = require('../machine-loader')
function buildMessage (alerts, notifications) { function buildMessage (alerts, notifications) {
const smsEnabled = utils.isActive(notifications.sms) const smsEnabled = utils.isActive(notifications.sms)
const emailEnabled = utils.isActive(notifications.email) const emailEnabled = utils.isActive(notifications.email)
@ -158,7 +160,7 @@ function transactionNotify (tx, rec) {
if (!zeroConf && rec.isRedemption) return sendRedemptionMessage(tx.id, rec.error) if (!zeroConf && rec.isRedemption) return sendRedemptionMessage(tx.id, rec.error)
return Promise.all([ return Promise.all([
queries.getMachineName(tx.deviceId), getMachineName(tx.deviceId),
customerPromise customerPromise
]).then(([machineName, customer]) => { ]).then(([machineName, customer]) => {
return utils.buildTransactionMessage(tx, rec, highValueTx, machineName, customer) return utils.buildTransactionMessage(tx, rec, highValueTx, machineName, customer)
@ -169,7 +171,7 @@ function transactionNotify (tx, rec) {
function complianceNotify (customer, deviceId, action, period) { function complianceNotify (customer, deviceId, action, period) {
return Promise.all([ return Promise.all([
settingsLoader.loadLatest(), settingsLoader.loadLatest(),
queries.getMachineName(deviceId) getMachineName(deviceId)
]) ])
.then(([settings, machineName]) => { .then(([settings, machineName]) => {
const notifications = configManager.getGlobalNotifications(settings.config) const notifications = configManager.getGlobalNotifications(settings.config)
@ -267,7 +269,7 @@ function sendTransactionMessage (rec, isHighValueTx) {
function cashboxNotify (deviceId) { function cashboxNotify (deviceId) {
return Promise.all([ return Promise.all([
settingsLoader.loadLatest(), settingsLoader.loadLatest(),
queries.getMachineName(deviceId) getMachineName(deviceId)
]) ])
.then(([settings, machineName]) => { .then(([settings, machineName]) => {
const notifications = configManager.getGlobalNotifications(settings.config) const notifications = configManager.getGlobalNotifications(settings.config)

7
lib/notifier/queries.js
View file

@ -15,12 +15,6 @@ compliance - notifications related to warnings triggered by compliance settings
error - notifications related to errors error - notifications related to errors
*/ */
function getMachineName (machineId) {
const sql = 'SELECT * FROM devices WHERE device_id=$1'
return db.oneOrNone(sql, [machineId])
.then(it => it.name).catch(logger.error)
}
const addNotification = (type, message, detail) => { const addNotification = (type, message, detail) => {
const sql = `INSERT INTO notifications (id, type, message, detail) VALUES ($1, $2, $3, $4)` const sql = `INSERT INTO notifications (id, type, message, detail) VALUES ($1, $2, $3, $4)`
return db.oneOrNone(sql, [uuidv4(), type, message, detail]).catch(logger.error) return db.oneOrNone(sql, [uuidv4(), type, message, detail]).catch(logger.error)
@ -105,5 +99,4 @@ module.exports = {
markAllAsRead, markAllAsRead,
hasUnreadNotifications, hasUnreadNotifications,
getAlerts, getAlerts,
getMachineName
} }