From da8435ec0d008de2b5ebb71f57e8f871978306a5 Mon Sep 17 00:00:00 2001
From: siiky <github-siiky@net-c.cat>
Date: Wed, 22 Nov 2023 17:55:51 +0000
Subject: [PATCH] refactor: abstract away getting ticker rates

---
 lib/plugins.js | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/lib/plugins.js b/lib/plugins.js
index 4a7ba823..c59ad65e 100644
--- a/lib/plugins.js
+++ b/lib/plugins.js
@@ -274,12 +274,16 @@ function plugins (settings, deviceId) {
     }
   }
 
+  function getTickerRates (fiatCode, cryptoCode) {
+    return ticker.getRates(settings, fiatCode, cryptoCode)
+  }
+
   function pollQueries () {
     const localeConfig = configManager.getLocale(deviceId, settings.config)
     const fiatCode = localeConfig.fiatCurrency
     const cryptoCodes = localeConfig.cryptoCurrencies
 
-    const tickerPromises = cryptoCodes.map(c => ticker.getRates(settings, fiatCode, c))
+    const tickerPromises = cryptoCodes.map(c => getTickerRates(fiatCode, c))
     const balancePromises = cryptoCodes.map(c => fiatBalance(fiatCode, c))
     const networkPromises = cryptoCodes.map(c => wallet.cryptoNetwork(settings, c))
     const supportsBatchingPromise = cryptoCodes.map(c => wallet.supportsBatching(settings, c))
@@ -394,7 +398,7 @@ function plugins (settings, deviceId) {
   function fiatBalance (fiatCode, cryptoCode) {
     const commissions = configManager.getCommissions(cryptoCode, deviceId, settings.config)
     return Promise.all([
-      ticker.getRates(settings, fiatCode, cryptoCode),
+      getTickerRates(fiatCode, cryptoCode),
       wallet.balance(settings, cryptoCode)
     ])
       .then(([rates, balanceRec]) => {
@@ -965,7 +969,7 @@ function plugins (settings, deviceId) {
     const fiatCode = localeConfig.fiatCurrency
 
     const cryptoCodes = configManager.getAllCryptoCurrencies(settings.config)
-    const tickerPromises = cryptoCodes.map(c => ticker.getRates(settings, fiatCode, c))
+    const tickerPromises = cryptoCodes.map(c => getTickerRates(fiatCode, c))
 
     return Promise.all(tickerPromises)
   }