diff --git a/new-lamassu-admin/src/pages/Accounting/Accounting.js b/new-lamassu-admin/src/pages/Accounting/Accounting.js index 74d65a88..fbde444d 100644 --- a/new-lamassu-admin/src/pages/Accounting/Accounting.js +++ b/new-lamassu-admin/src/pages/Accounting/Accounting.js @@ -114,7 +114,7 @@ const Accounting = () => { const { data: configResponse, loading: configLoading } = useQuery(GET_DATA) const timezone = R.path(['config', 'locale_timezone'], configResponse) - const loading = operatorLoading && configLoading + const loading = operatorLoading || configLoading const operatorData = R.path(['operatorByUsername'], opData) @@ -170,26 +170,22 @@ const Accounting = () => { ] return ( - !loading && ( - <> - - -

Fiat balance history

- - - ) + <> + + +

Fiat balance history

+ + ) } diff --git a/new-lamassu-admin/src/pages/Customers/CustomerProfile.js b/new-lamassu-admin/src/pages/Customers/CustomerProfile.js index dece97bf..151276aa 100644 --- a/new-lamassu-admin/src/pages/Customers/CustomerProfile.js +++ b/new-lamassu-admin/src/pages/Customers/CustomerProfile.js @@ -381,7 +381,7 @@ const CustomerProfile = memo(() => { const photosData = formatPhotosData(R.append(frontCameraData, txPhotosData)) - const loading = customerLoading && configLoading + const loading = customerLoading || configLoading const timezone = R.path(['config', 'locale_timezone'], configResponse) diff --git a/new-lamassu-admin/src/pages/LoyaltyPanel/IndividualDiscounts.js b/new-lamassu-admin/src/pages/LoyaltyPanel/IndividualDiscounts.js index b9585d76..c3b95470 100644 --- a/new-lamassu-admin/src/pages/LoyaltyPanel/IndividualDiscounts.js +++ b/new-lamassu-admin/src/pages/LoyaltyPanel/IndividualDiscounts.js @@ -64,7 +64,9 @@ const IndividualDiscounts = () => { const [showModal, setShowModal] = useState(false) const toggleModal = () => setShowModal(!showModal) - const { data: discountResponse, loading } = useQuery(GET_INDIVIDUAL_DISCOUNTS) + const { data: discountResponse, loading: discountLoading } = useQuery( + GET_INDIVIDUAL_DISCOUNTS + ) const { data: customerData, loading: customerLoading } = useQuery( GET_CUSTOMERS ) @@ -160,11 +162,11 @@ const IndividualDiscounts = () => { } ] - const isLoading = loading || customerLoading + const loading = discountLoading || customerLoading return ( <> - {!isLoading && !R.isEmpty(discountResponse.individualDiscounts) && ( + {!loading && !R.isEmpty(discountResponse.individualDiscounts) && ( { )} - {!isLoading && !R.isEmpty(discountResponse.individualDiscounts) && ( + {!loading && !R.isEmpty(discountResponse.individualDiscounts) && ( <> { /> )} - {!isLoading && R.isEmpty(discountResponse.individualDiscounts) && ( + {!loading && R.isEmpty(discountResponse.individualDiscounts) && ( It seems there are no active individual customer discounts on your diff --git a/new-lamassu-admin/src/pages/MachineLogs.js b/new-lamassu-admin/src/pages/MachineLogs.js index 277b82c5..d06f4a2c 100644 --- a/new-lamassu-admin/src/pages/MachineLogs.js +++ b/new-lamassu-admin/src/pages/MachineLogs.js @@ -81,16 +81,21 @@ const Logs = () => { const deviceId = selected?.deviceId - const { data: machineResponse } = useQuery(GET_MACHINES) + const { data: machineResponse, loading: machinesLoading } = useQuery( + GET_MACHINES + ) - const { data: configResponse } = useQuery(GET_DATA) + const { data: configResponse, loading: configLoading } = useQuery(GET_DATA) const timezone = R.path(['config', 'locale_timezone'], configResponse) - const { data: logsResponse, loading } = useQuery(GET_MACHINE_LOGS, { - variables: { deviceId, limit: NUM_LOG_RESULTS }, - skip: !selected, - onCompleted: () => setSaveMessage('') - }) + const { data: logsResponse, loading: logsLoading } = useQuery( + GET_MACHINE_LOGS, + { + variables: { deviceId, limit: NUM_LOG_RESULTS }, + skip: !selected, + onCompleted: () => setSaveMessage('') + } + ) if (machineResponse?.machines?.length && !selected) { setSelected(machineResponse?.machines[0]) @@ -100,6 +105,8 @@ const Logs = () => { return R.path(['deviceId'])(selected) === it.deviceId } + const loading = machinesLoading || configLoading || logsLoading + return ( <>
diff --git a/new-lamassu-admin/src/pages/Machines/MachineComponents/Transactions/Transactions.js b/new-lamassu-admin/src/pages/Machines/MachineComponents/Transactions/Transactions.js index dedd15e0..a5902611 100644 --- a/new-lamassu-admin/src/pages/Machines/MachineComponents/Transactions/Transactions.js +++ b/new-lamassu-admin/src/pages/Machines/MachineComponents/Transactions/Transactions.js @@ -82,7 +82,7 @@ const Transactions = ({ id }) => { const { data: configData, loading: configLoading } = useQuery(GET_DATA) const timezone = R.path(['config', 'locale_timezone'], configData) - const loading = txLoading && configLoading + const loading = txLoading || configLoading if (!loading && txResponse) { txResponse.transactions = txResponse.transactions.splice(0, 5) diff --git a/new-lamassu-admin/src/pages/Maintenance/CashboxHistory.js b/new-lamassu-admin/src/pages/Maintenance/CashboxHistory.js index 2a98fd35..70ca9fcf 100644 --- a/new-lamassu-admin/src/pages/Maintenance/CashboxHistory.js +++ b/new-lamassu-admin/src/pages/Maintenance/CashboxHistory.js @@ -85,7 +85,7 @@ const CashboxHistory = ({ machines, currency }) => { const { data: configData, loading: configLoading } = useQuery(GET_DATA) const timezone = R.path(['config', 'locale_timezone'], configData) - const loading = batchesLoading && configLoading + const loading = batchesLoading || configLoading const batches = R.path(['cashboxBatches'])(batchesData) @@ -248,16 +248,13 @@ const CashboxHistory = ({ machines, currency }) => { ] return ( - <> - {!loading && ( - - )} - + ) } diff --git a/new-lamassu-admin/src/pages/Maintenance/MachineStatus.js b/new-lamassu-admin/src/pages/Maintenance/MachineStatus.js index 2c3ac5da..23512947 100644 --- a/new-lamassu-admin/src/pages/Maintenance/MachineStatus.js +++ b/new-lamassu-admin/src/pages/Maintenance/MachineStatus.js @@ -54,7 +54,11 @@ const MachineStatus = () => { const history = useHistory() const { state } = useLocation() const addedMachineId = state?.id - const { data: machinesResponse, refetch, loading } = useQuery(GET_MACHINES) + const { + data: machinesResponse, + refetch, + loading: machinesLoading + } = useQuery(GET_MACHINES) const { data: configResponse, configLoading } = useQuery(GET_DATA) const timezone = R.path(['config', 'locale_timezone'], configResponse) @@ -114,6 +118,8 @@ const MachineStatus = () => { ) + const loading = machinesLoading || configLoading + return ( <>
@@ -132,7 +138,7 @@ const MachineStatus = () => {
{ const [saveMessage, setSaveMessage] = useState(null) const [logLevel, setLogLevel] = useState(SHOW_ALL) - const { data, loading } = useQuery(GET_SERVER_DATA, { + const { data, loading: dataLoading } = useQuery(GET_SERVER_DATA, { onCompleted: () => setSaveMessage(''), variables: { limit: NUM_LOG_RESULTS } }) - const { data: configResponse, configLoading } = useQuery(GET_DATA) + const { data: configResponse, loading: configLoading } = useQuery(GET_DATA) const timezone = R.path(['config', 'locale_timezone'], configResponse) const defaultLogLevels = [ @@ -132,6 +132,8 @@ const Logs = () => { setLogLevel(logLevel) } + const loading = dataLoading || configLoading + return ( <>
@@ -206,8 +208,8 @@ const Logs = () => { ))} - {loading && configLoading &&

{'Loading...'}

} - {!loading && !configLoading && !data?.serverLogs?.length && ( + {loading &&

{'Loading...'}

} + {!loading && !data?.serverLogs?.length && (

{'No activity so far'}

)}
diff --git a/new-lamassu-admin/src/pages/SessionManagement/SessionManagement.js b/new-lamassu-admin/src/pages/SessionManagement/SessionManagement.js index 9ce5ab12..d40c5e0a 100644 --- a/new-lamassu-admin/src/pages/SessionManagement/SessionManagement.js +++ b/new-lamassu-admin/src/pages/SessionManagement/SessionManagement.js @@ -48,7 +48,7 @@ const SessionManagement = () => { const { data: configResponse, loading: configLoading } = useQuery(GET_DATA) const timezone = R.path(['config', 'locale_timezone'], configResponse) - const loading = sessionsLoading && configLoading + const loading = sessionsLoading || configLoading const elements = [ { @@ -107,15 +107,14 @@ const SessionManagement = () => { ] return ( - !loading && ( - <> - - - - ) + <> + + + ) }