From 5892d3b3c0d3ac18594d5071bb2f6732844de137 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9rgio=20Salgado?= Date: Fri, 19 Nov 2021 19:41:57 +0000 Subject: [PATCH 1/2] fix: user management css fix: get production hostname to create links --- .../pages/UserManagement/UserManagement.js | 70 ++++++++----------- .../UserManagement/UserManagement.styles.js | 21 ++++-- new-lamassu-admin/src/utils/urlResolver.js | 4 +- 3 files changed, 48 insertions(+), 47 deletions(-) diff --git a/new-lamassu-admin/src/pages/UserManagement/UserManagement.js b/new-lamassu-admin/src/pages/UserManagement/UserManagement.js index 76e560ca..9930dc3d 100644 --- a/new-lamassu-admin/src/pages/UserManagement/UserManagement.js +++ b/new-lamassu-admin/src/pages/UserManagement/UserManagement.js @@ -53,6 +53,11 @@ const reducer = (_, action) => { } } +const roleMapper = { + user: 'Regular', + superuser: 'Superuser' +} + const Users = () => { const classes = useStyles() const { userData } = useContext(AppContext) @@ -65,63 +70,44 @@ const Users = () => { const elements = [ { header: 'Login', - width: 257, + width: 307, textAlign: 'left', size: 'sm', view: u => { if (userData.id === u.id) return ( - <> - {u.username} +
+ {u.username} - +
) - return u.username + return {u.username} } }, { header: 'Role', - width: 105, - textAlign: 'center', - size: 'sm', - view: u => { - switch (u.role) { - case 'user': - return 'Regular' - case 'superuser': - return 'Superuser' - default: - return u.role - } - } - }, - { - header: '', - width: 80, - textAlign: 'center', + width: 160, + textAlign: 'left', size: 'sm', view: u => ( - { - setUserInfo(u) - dispatch({ - type: 'open', - payload: 'showRoleModal' - }) - }} - value={u.role === 'superuser'} - /> +
+ {roleMapper[u.role]} + { + setUserInfo(u) + dispatch({ + type: 'open', + payload: 'showRoleModal' + }) + }} + value={u.role === 'superuser'} + /> +
) }, - { - header: '', - width: 25, - textAlign: 'center', - size: 'sm', - view: u => {} - }, { header: 'Actions', width: 565, diff --git a/new-lamassu-admin/src/pages/UserManagement/UserManagement.styles.js b/new-lamassu-admin/src/pages/UserManagement/UserManagement.styles.js index 5ac645c7..9366e555 100644 --- a/new-lamassu-admin/src/pages/UserManagement/UserManagement.styles.js +++ b/new-lamassu-admin/src/pages/UserManagement/UserManagement.styles.js @@ -50,13 +50,11 @@ const styles = { chip: { backgroundColor: subheaderColor, fontFamily: fontPrimary, - marginLeft: 15, - marginTop: -5 + marginLeft: 10 }, actionChip: { backgroundColor: subheaderColor, - marginRight: 15, - marginTop: -5 + marginRight: 15 }, info: { fontFamily: fontSecondary, @@ -105,6 +103,21 @@ const styles = { height: '100%', overflow: 'hidden', position: 'relative' + }, + loginWrapper: { + display: 'flex', + flexDirection: 'row', + alignItems: 'center', + justifyContent: 'space-between' + }, + username: { + overflow: 'hidden', + whiteSpace: 'nowrap', + textOverflow: 'ellipsis', + width: '100%' + }, + roleSwitch: { + marginLeft: 15 } } diff --git a/new-lamassu-admin/src/utils/urlResolver.js b/new-lamassu-admin/src/utils/urlResolver.js index 5e0785bb..edb823a9 100644 --- a/new-lamassu-admin/src/utils/urlResolver.js +++ b/new-lamassu-admin/src/utils/urlResolver.js @@ -1,5 +1,7 @@ const url = - process.env.NODE_ENV === 'development' ? 'https://localhost:3001' : '' + process.env.NODE_ENV === 'development' + ? 'https://localhost:3001' + : `https://${window.location.hostname}` const urlResolver = content => `${url}${content}` From ea51c62b80e1d731e04ea151f09c1a7c788a35bd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9rgio=20Salgado?= Date: Fri, 19 Nov 2021 19:44:37 +0000 Subject: [PATCH 2/2] fix: remove usage of env var --- new-lamassu-admin/src/utils/urlResolver.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/new-lamassu-admin/src/utils/urlResolver.js b/new-lamassu-admin/src/utils/urlResolver.js index edb823a9..9e4ac8cb 100644 --- a/new-lamassu-admin/src/utils/urlResolver.js +++ b/new-lamassu-admin/src/utils/urlResolver.js @@ -1,7 +1,4 @@ -const url = - process.env.NODE_ENV === 'development' - ? 'https://localhost:3001' - : `https://${window.location.hostname}` +const url = `https://${window.location.hostname}` const urlResolver = content => `${url}${content}`