From e951d1341cdccf5ecfadebb79237d3d8d1382525 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Oliveira?= <josepfo.w@gmail.com>
Date: Tue, 11 May 2021 14:02:13 +0100
Subject: [PATCH] refactor: simplify object construction

---
 ...8992683-fiat-balance-notification-to-percent.js | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/migrations/1619968992683-fiat-balance-notification-to-percent.js b/migrations/1619968992683-fiat-balance-notification-to-percent.js
index bfbeae77..193089f3 100644
--- a/migrations/1619968992683-fiat-balance-notification-to-percent.js
+++ b/migrations/1619968992683-fiat-balance-notification-to-percent.js
@@ -20,17 +20,17 @@ exports.up = function (next) {
 
       if (overrides) {
         newConfig.notifications_fiatBalanceOverrides = _.map(override => {
+          const newOverride = {}
           if (override.fiatBalanceCassette1) {
-            override.fiatBalanceCassette1 = (100 * (override.fiatBalanceCassette1 / cassetteMaxCapacity)).toFixed(0)
+            newOverride.fillingPercentageCassette1 = (100 * (override.fiatBalanceCassette1 / cassetteMaxCapacity)).toFixed(0)
           }
           if (override.fiatBalanceCassette2) {
-            override.fiatBalanceCassette2 = (100 * (override.fiatBalanceCassette2 / cassetteMaxCapacity)).toFixed(0)
+            newOverride.fillingPercentageCassette2 = (100 * (override.fiatBalanceCassette2 / cassetteMaxCapacity)).toFixed(0)
           }
-          const {
-            fiatBalanceCassette1: fillingPercentageCassette1,
-            fiatBalanceCassette2: fillingPercentageCassette2,
-            ...rest } = override
-          return { fillingPercentageCassette1, fillingPercentageCassette2, ...rest }
+          newOverride.machine = override.machine
+          newOverride.id = override.id
+
+          return newOverride
         }, config.notifications_fiatBalanceOverrides)
       }
       return saveConfig(newConfig)