Refactors duplicate payment check in Fava

Improves payment recording logic by fetching recent entries and filtering using Python, replacing the BQL query.

This addresses issues with matching against set types in BQL, enhancing reliability.

tasks.py

@@ -152,16 +152,26 @@ async def on_invoice_paid(payment: Payment) -> None:
     fava = get_fava_client()
 
     try:
-        # Query Fava for existing payment entry
+        # Check if payment already recorded by fetching recent entries
-        query = f"SELECT * WHERE links ~ 'ln-{payment.payment_hash[:16]}'"
+        # Note: We can't use BQL query with `links ~ 'pattern'` because links is a set type
-        async with httpx.AsyncClient(timeout=5.0) as client:
+        # and BQL doesn't support regex matching on sets. Instead, fetch entries and filter in Python.
-            response = await client.get(
+        link_to_find = f"ln-{payment.payment_hash[:16]}"
-                f"{fava.base_url}/query",
-                params={"query_string": query}
-            )
-            result = response.json()
 
-            if result.get('data', {}).get('rows'):
+        async with httpx.AsyncClient(timeout=5.0) as client:
+            # Get recent entries from Fava's journal endpoint
+            response = await client.get(
+                f"{fava.base_url}/api/journal",
+                params={"time": ""}  # Get all entries
+            )
+
+            if response.status_code == 200:
+                data = response.json()
+                entries = data.get('entries', [])
+
+                # Check if any entry has our payment link
+                for entry in entries:
+                    entry_links = entry.get('links', [])
+                    if link_to_find in entry_links:
                         logger.info(f"Payment {payment.payment_hash} already recorded in Fava, skipping")
                         return
 

views_api.py

@@ -1356,17 +1356,27 @@ async def api_record_payment(
 
     fava = get_fava_client()
 
-    # Query Fava for existing entry with this payment hash link
+    # Check if payment already recorded by fetching recent entries
-    query = f"SELECT * WHERE links ~ 'ln-{data.payment_hash[:16]}'"
+    # Note: We can't use BQL query with `links ~ 'pattern'` because links is a set type
+    # and BQL doesn't support regex matching on sets. Instead, fetch entries and filter in Python.
+    link_to_find = f"ln-{data.payment_hash[:16]}"
+
     try:
         async with httpx.AsyncClient(timeout=5.0) as client:
+            # Get recent entries from Fava's journal endpoint
             response = await client.get(
-                f"{fava.base_url}/query",
+                f"{fava.base_url}/api/journal",
-                params={"query_string": query}
+                params={"time": ""}  # Get all entries
             )
-            result = response.json()
 
-            if result.get('data', {}).get('rows'):
+            if response.status_code == 200:
+                response_data = response.json()
+                entries = response_data.get('entries', [])
+
+                # Check if any entry has our payment link
+                for entry in entries:
+                    entry_links = entry.get('links', [])
+                    if link_to_find in entry_links:
                         # Payment already recorded, return existing entry
                         balance_data = await fava.get_user_balance(target_user_id)
                         return {