lamassu/lamassu-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: remove unnecessary bn config and isBigNumber usage

Browse source
This commit is contained in:
José Oliveira 2021-06-28 19:59:48 +01:00 • committed by Josh Harvey
parent 2cafe074b2
commit 6537938ec3
2 changed files with 8 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

9
lib/bn.js
View file

@ -1,10 +1,5 @@
const BigNumber = require('bignumber.js') const BigNumber = require('bignumber.js')
BigNumber.config({ROUNDING_MODE: BigNumber.ROUND_HALF_EVEN}) BigNumber.config({ ROUNDING_MODE: BigNumber.ROUND_HALF_EVEN })
function BN (s, radix) { return new BigNumber(s, radix) } module.exports = BigNumber
BN.min = BigNumber.min
BN.max = BigNumber.max
module.exports = BN

11
lib/cash-in/cash-in-low.js
View file

@ -20,9 +20,10 @@ const massageUpdates = _.flow(_.omit(massageUpdateFields),
module.exports = {toObj, upsert, insert, update, massage, isClearToSend} module.exports = {toObj, upsert, insert, update, massage, isClearToSend}
function convertBigNumFields (obj) { function convertBigNumFields (obj) {
const convert = value => value && value._isBigNumber const convert = value =>
? value.toString() value && BN.isBigNumber(value)
: value ? value.toString()
: value
return _.mapValues(convert, obj) return _.mapValues(convert, obj)
} }
@ -113,7 +114,7 @@ function ensureRatchet (oldField, newField, fieldKey) {
} }
if (_.isNil(newField)) return false if (_.isNil(newField)) return false
if (oldField.isBigNumber && newField.isBigNumber) return new BN(oldField).eq(newField) if (BN.isBigNumber(oldField) && BN.isBigNumber(newField)) return new BN(oldField).eq(newField)
if (oldField.toString() === newField.toString()) return true if (oldField.toString() === newField.toString()) return true
return false return false
@ -122,7 +123,7 @@ function ensureRatchet (oldField, newField, fieldKey) {
function isMonotonic (oldField, newField, fieldKey) { function isMonotonic (oldField, newField, fieldKey) {
if (_.isNil(newField)) return false if (_.isNil(newField)) return false
if (_.isBoolean(oldField)) return oldField === newField || !oldField if (_.isBoolean(oldField)) return oldField === newField || !oldField
if (oldField.isBigNumber) return oldField.lte(newField) if (BN.isBigNumber(oldField)) return oldField.lte(newField)
if (_.isNumber(oldField)) return oldField <= newField if (_.isNumber(oldField)) return oldField <= newField
throw new Error(`Unexpected value [${fieldKey}]: ${oldField}, ${newField}`) throw new Error(`Unexpected value [${fieldKey}]: ${oldField}, ${newField}`)